google-nomulus/integration/run_schema_check.sh
Weimin Yu 09dd6580d2 Cover more base in forbidden SQL change check (#785)
* Cover more base in forbidden SQL change check

Update the forbidden SQL change detection script to include file deletion and
renaming as well as edits.
2020-08-31 15:08:37 -04:00

80 lines
2.7 KiB
Bash
Executable file

#!/bin/bash
# Copyright 2020 The Nomulus Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# This script runs the sqlIntegrationTestSuite in a given server release
# against a specific Cloud SQL schema release. When invoked during presubmit
# tests, it detects code or schema changes that are incompatible with current
# deployments in production.
USAGE="
$(basename "$0") [--help]
or
$(basename "$0") OPTIONS
Checks for post-deployment change to Flyway scripts.
With Flyway, once an incremental change script is deployed, it must not be
changed. Even changes to comments or whitespaces would cause validation
failures during future deployment. This script checks for changes (including
removal and renaming which may happen due to incorrect merge conflict
resolution) to scripts that have already been deployed to Sandbox. The
assumption is that the schema in Sandbox is always newer than that in
production.
A side-effect of this check is that old branches missing recently deployed
scripts must update first.
Options:
-h, --help show this help text
-p, --project
the GCP project with deployment infrastructure. It should
take the devProject property defined in the Gradle root
project."
SCRIPT_DIR="$(realpath $(dirname $0))"
. "${SCRIPT_DIR}/testutils_bashrc"
set -e
eval set -- $(getopt -o p:s:e:h -l project:,sut:,env:,help -- "$@")
while true; do
case "$1" in
-p | --project) DEV_PROJECT="$2"; shift 2 ;;
-h | --help) echo "${USAGE}"; exit 0 ;;
--) shift; break ;;
*) echo "${USAGE}"; exit 1 ;;
esac
done
if [[ -z "${DEV_PROJECT}" ]]; then
echo "${USAGE}"
exit 1
fi
sandbox_tag=$(fetchVersion sql sandbox ${DEV_PROJECT})
echo "Checking Flyway scripts against schema in Sandbox (${sandbox_tag})."
modified_sqls=$(git diff --name-status ${sandbox_tag} \
db/src/main/resources/sql/flyway | grep "^M\|^D\|^R" | grep \.sql$ | wc -l)
if [[ ${modified_sqls} = 0 ]]; then
echo "No illegal change to deployed schema scripts."
exit 0
else
echo "Changes to the following files are not allowed:"
echo $(git diff --name-status ${sandbox_tag} \
db/src/main/resources/sql/flyway | grep "^M\|^D\|^R" | grep \.sql$)
echo "Make sure your branch is up to date with HEAD of master."
exit 1
fi