google-nomulus/javatests/google/registry
nickfelt 0405a427f1 Remove unnecessary SecureRandom from UrlFetchUtils
We're only using it for generating multiparty boundaries, and there's no real need for the random boundary values to be cryptographically secure.  The point of the randomness is just to make collisions with content in the payload sufficiently unlikely.  The app itself controls the payload contents, and while it might be derived from user-submitted content, in practice it would be nearly infeasible to get the payload to contain arbitrary boundary values even if the RNG-produced boundaries could be determined in advance.

To further insulate against this, I've increased the boundary size (from 40 bits to 192) and added an actual check that the boundary isn't present in the input data, so that in the extremely unlikely event of a collision, we fail rather than producing an invalid multipart request.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=142784289
2016-12-22 16:10:44 -05:00
..
backup Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
batch Move VerifyEntityIntegrityAction to batch package 2016-12-19 11:09:20 -05:00
bigquery Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
builddefs Upgrade Nomulus to latest Closure Rules 2016-12-06 11:52:46 -05:00
config Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
cron Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
dns Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
export Clean up some more TLD-specific code 2016-12-19 11:09:20 -05:00
flows Reconcile FeesAndCredits handling in price customization 2016-12-22 16:09:14 -05:00
groups Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
mapreduce/inputs Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
model Remove deprecated extra flow logic and TLD-specific pricing proxy 2016-12-19 11:09:20 -05:00
module Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
monitoring Move VerifyEntityIntegrityAction to batch package 2016-12-19 11:09:20 -05:00
pricing Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
rdap Inject RDAP help information in ConfigModule 2016-12-06 11:52:46 -05:00
rde Increase rde package test size 2016-12-19 11:09:19 -05:00
request Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
security Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
server Fix Objectify versions in imports in javatests packages 2016-12-14 09:45:03 -05:00
storage/drive Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
testing Prefer Multimap interface types over implementation types. 2016-12-07 15:19:35 -05:00
tldconfig/idn Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
tmch Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
tools Correctly set HTTP error status codes when list objects fails 2016-12-06 11:52:46 -05:00
ui Upgrade Nomulus to latest Closure Rules 2016-12-06 11:52:46 -05:00
util Remove unnecessary SecureRandom from UrlFetchUtils 2016-12-22 16:10:44 -05:00
whois Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
xjc Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
xml Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00