mirror of
https://github.com/google/nomulus.git
synced 2025-06-02 02:28:40 +02:00
In addition to just making good sense to not have support group for some environments (local? unittest? crash?) - connecting with G Suit requires additional permissions that are harder to find. Specifically, it requires the Json Credentials that just aren't set in the Dummy Keyring used on some environments. So we make sure to not even *try* to create the credentials if the support email isn't set ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=225589255
319 lines
12 KiB
Java
319 lines
12 KiB
Java
// Copyright 2018 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.request.auth;
|
|
|
|
import static com.google.common.base.MoreObjects.toStringHelper;
|
|
import static com.google.common.base.Preconditions.checkNotNull;
|
|
import static google.registry.model.ofy.ObjectifyService.ofy;
|
|
|
|
import com.google.appengine.api.users.User;
|
|
import com.google.common.annotations.VisibleForTesting;
|
|
import com.google.common.base.Strings;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.google.common.collect.ImmutableSetMultimap;
|
|
import com.google.common.flogger.FluentLogger;
|
|
import dagger.Lazy;
|
|
import google.registry.config.RegistryConfig.Config;
|
|
import google.registry.groups.GroupsConnection;
|
|
import google.registry.model.registrar.Registrar;
|
|
import google.registry.model.registrar.RegistrarContact;
|
|
import java.util.Optional;
|
|
import javax.annotation.concurrent.Immutable;
|
|
import javax.inject.Inject;
|
|
|
|
/**
|
|
* Allows access only to {@link Registrar}s the current user has access to.
|
|
*
|
|
* <p>A user has OWNER role on a Registrar if there exists a {@link RegistrarContact} with that
|
|
* user's gaeId and the registrar as a parent.
|
|
*
|
|
* <p>An "admin" has in addition OWNER role on {@code #registryAdminClientId} and to all non-{@code
|
|
* REAL} registrars (see {@link Registrar#getType}).
|
|
*
|
|
* <p>An "admin" also has ADMIN role on ALL registrars.
|
|
*
|
|
* <p>A user is an "admin" if they are a GAE-admin, or if their email is in the "Support" G Suite
|
|
* group.
|
|
*
|
|
* <p>NOTE: to check whether the user is in the "Support" G Suite group, we need a connection to
|
|
* G Suite. This in turn requires we have valid JsonCredentials, which not all environments have set
|
|
* up. This connection will be created lazily (only if needed).
|
|
*
|
|
* <p>Specifically, we don't instantiate the connection if: (a) gSuiteSupportGroupEmailAddress isn't
|
|
* defined, or (b) the user is logged out, or (c) the user is a GAE-admin, or (d) bypassAdminCheck
|
|
* is true.
|
|
*/
|
|
@Immutable
|
|
public class AuthenticatedRegistrarAccessor {
|
|
|
|
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
|
|
|
|
/** The role under which access is granted. */
|
|
public enum Role {
|
|
OWNER,
|
|
ADMIN
|
|
}
|
|
|
|
private final String userIdForLogging;
|
|
|
|
/**
|
|
* Gives all roles a user has for a given clientId.
|
|
*
|
|
* <p>The order is significant, with "more specific to this user" coming first.
|
|
*
|
|
* <p>Logged out users have an empty roleMap.
|
|
*/
|
|
private final ImmutableSetMultimap<String, Role> roleMap;
|
|
|
|
/**
|
|
* Bypass the "isAdmin" check making all users NOT admins.
|
|
*
|
|
* <p>Currently our test server doesn't let you change the user after the test server was created.
|
|
* This means we'd need multiple test files to test the same actions as both a "regular" user and
|
|
* an admin.
|
|
*
|
|
* <p>To overcome this - we add a flag that lets you dynamically choose whether a user is an admin
|
|
* or not by creating a fake "GAE-admin" user and then bypassing the admin check if they want to
|
|
* fake a "regular" user.
|
|
*
|
|
* <p>The reason we don't do it the other way around (have a flag that makes anyone an admin) is
|
|
* that such a flag would be a security risk, especially since VisibleForTesting is unenforced
|
|
* (and you could set it with reflection anyway).
|
|
*
|
|
* <p>Instead of having a test flag that elevates permissions (which has security concerns) we add
|
|
* this flag that reduces permissions.
|
|
*/
|
|
@VisibleForTesting public static boolean bypassAdminCheck = false;
|
|
|
|
@Inject
|
|
public AuthenticatedRegistrarAccessor(
|
|
AuthResult authResult,
|
|
@Config("registryAdminClientId") String registryAdminClientId,
|
|
@Config("gSuiteSupportGroupEmailAddress") Optional<String> gSuiteSupportGroupEmailAddress,
|
|
Lazy<GroupsConnection> lazyGroupsConnection) {
|
|
this(
|
|
authResult.userIdForLogging(),
|
|
createRoleMap(
|
|
authResult,
|
|
registryAdminClientId,
|
|
lazyGroupsConnection,
|
|
gSuiteSupportGroupEmailAddress));
|
|
|
|
logger.atInfo().log(
|
|
"%s has the following roles: %s", authResult.userIdForLogging(), roleMap);
|
|
}
|
|
|
|
private AuthenticatedRegistrarAccessor(
|
|
String userIdForLogging, ImmutableSetMultimap<String, Role> roleMap) {
|
|
this.userIdForLogging = checkNotNull(userIdForLogging);
|
|
this.roleMap = checkNotNull(roleMap);
|
|
}
|
|
|
|
/**
|
|
* Creates a "logged-in user" accessor with a given role map, used for tests.
|
|
*
|
|
* <p>The user's "name" in logs and exception messages is "TestUserId".
|
|
*/
|
|
@VisibleForTesting
|
|
public static AuthenticatedRegistrarAccessor createForTesting(
|
|
ImmutableSetMultimap<String, Role> roleMap) {
|
|
return new AuthenticatedRegistrarAccessor("TestUserId", roleMap);
|
|
}
|
|
|
|
/**
|
|
* A map that gives all roles a user has for a given clientId.
|
|
*
|
|
* <p>Throws a {@link RegistrarAccessDeniedException} if the user is not logged in.
|
|
*
|
|
* <p>The result is ordered starting from "most specific to this user".
|
|
*
|
|
* <p>If you want to load the {@link Registrar} object from these (or any other) {@code clientId},
|
|
* in order to perform actions on behalf of a user, you must use {@link #getRegistrar} which makes
|
|
* sure the user has permissions.
|
|
*
|
|
* <p>Note that this is an OPTIONAL step in the authentication - only used if we don't have any
|
|
* other clue as to the requested {@code clientId}. It is perfectly OK to get a {@code clientId}
|
|
* from any other source, as long as the registrar is then loaded using {@link #getRegistrar}.
|
|
*/
|
|
public ImmutableSetMultimap<String, Role> getAllClientIdWithRoles() {
|
|
return roleMap;
|
|
}
|
|
|
|
/**
|
|
* Returns all the roles the current user has on the given registrar.
|
|
*
|
|
* <p>This is syntactic sugar for {@code getAllClientIdWithRoles().get(clientId)}.
|
|
*/
|
|
public ImmutableSet<Role> getRolesForRegistrar(String clientId) {
|
|
return getAllClientIdWithRoles().get(clientId);
|
|
}
|
|
|
|
/**
|
|
* Checks if we have a given role for a given registrar.
|
|
*
|
|
* <p>This is syntactic sugar for {@code getAllClientIdWithRoles().containsEntry(clientId, role)}.
|
|
*/
|
|
public boolean hasRoleOnRegistrar(Role role, String clientId) {
|
|
return getAllClientIdWithRoles().containsEntry(clientId, role);
|
|
}
|
|
|
|
/**
|
|
* "Guesses" which client ID the user wants from all those they have access to.
|
|
*
|
|
* <p>If no such ClientIds exist, throws a RegistrarAccessDeniedException.
|
|
*
|
|
* <p>This should be the ClientId "most likely wanted by the user".
|
|
*
|
|
* <p>If you want to load the {@link Registrar} object from this (or any other) {@code clientId},
|
|
* in order to perform actions on behalf of a user, you must use {@link #getRegistrar} which makes
|
|
* sure the user has permissions.
|
|
*
|
|
* <p>Note that this is an OPTIONAL step in the authentication - only used if we don't have any
|
|
* other clue as to the requested {@code clientId}. It is perfectly OK to get a {@code clientId}
|
|
* from any other source, as long as the registrar is then loaded using {@link #getRegistrar}.
|
|
*/
|
|
public String guessClientId() throws RegistrarAccessDeniedException {
|
|
return getAllClientIdWithRoles().keySet().stream()
|
|
.findFirst()
|
|
.orElseThrow(
|
|
() ->
|
|
new RegistrarAccessDeniedException(
|
|
String.format("%s isn't associated with any registrar", userIdForLogging)));
|
|
}
|
|
|
|
/**
|
|
* Loads a Registrar IFF the user is authorized.
|
|
*
|
|
* <p>Throws a {@link RegistrarAccessDeniedException} if the user is not logged in, or not
|
|
* authorized to access the requested registrar.
|
|
*
|
|
* @param clientId ID of the registrar we request
|
|
*/
|
|
public Registrar getRegistrar(String clientId) throws RegistrarAccessDeniedException {
|
|
verifyAccess(clientId);
|
|
|
|
Registrar registrar =
|
|
Registrar.loadByClientId(clientId)
|
|
.orElseThrow(
|
|
() ->
|
|
new RegistrarAccessDeniedException(
|
|
String.format("Registrar %s not found", clientId)));
|
|
|
|
if (!clientId.equals(registrar.getClientId())) {
|
|
logger.atSevere().log(
|
|
"registrarLoader.apply(clientId) returned a Registrar with a different clientId. "
|
|
+ "Requested: %s, returned: %s.",
|
|
clientId, registrar.getClientId());
|
|
throw new RegistrarAccessDeniedException("Internal error - please check logs");
|
|
}
|
|
|
|
return registrar;
|
|
}
|
|
|
|
public void verifyAccess(String clientId) throws RegistrarAccessDeniedException {
|
|
ImmutableSet<Role> roles = getAllClientIdWithRoles().get(clientId);
|
|
|
|
if (roles.isEmpty()) {
|
|
throw new RegistrarAccessDeniedException(
|
|
String.format("%s doesn't have access to registrar %s", userIdForLogging, clientId));
|
|
}
|
|
logger.atInfo().log("%s has %s access to registrar %s.", userIdForLogging, roles, clientId);
|
|
}
|
|
|
|
public String userIdForLogging() {
|
|
return userIdForLogging;
|
|
}
|
|
|
|
@Override
|
|
public String toString() {
|
|
return toStringHelper(getClass()).add("user", userIdForLogging).toString();
|
|
}
|
|
|
|
private static boolean checkIsSupport(
|
|
Lazy<GroupsConnection> lazyGroupsConnection,
|
|
String userEmail,
|
|
Optional<String> gSuiteSupportGroupEmailAddress) {
|
|
if (!gSuiteSupportGroupEmailAddress.isPresent()) {
|
|
return false;
|
|
}
|
|
try {
|
|
return lazyGroupsConnection
|
|
.get()
|
|
.isMemberOfGroup(userEmail, gSuiteSupportGroupEmailAddress.get());
|
|
} catch (RuntimeException e) {
|
|
logger.atSevere().withCause(e).log(
|
|
"Error checking whether email %s belongs to support group %s."
|
|
+ " Skipping support role check",
|
|
userEmail, gSuiteSupportGroupEmailAddress);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
private static ImmutableSetMultimap<String, Role> createRoleMap(
|
|
AuthResult authResult,
|
|
String registryAdminClientId,
|
|
Lazy<GroupsConnection> lazyGroupsConnection,
|
|
Optional<String> gSuiteSupportGroupEmailAddress) {
|
|
|
|
if (!authResult.userAuthInfo().isPresent()) {
|
|
return ImmutableSetMultimap.of();
|
|
}
|
|
|
|
UserAuthInfo userAuthInfo = authResult.userAuthInfo().get();
|
|
|
|
User user = userAuthInfo.user();
|
|
// both GAE project admin and members of the gSuiteSupportGroupEmailAddress are considered
|
|
// admins for the RegistrarConsole.
|
|
boolean isAdmin =
|
|
bypassAdminCheck
|
|
? false
|
|
: userAuthInfo.isUserAdmin()
|
|
|| checkIsSupport(
|
|
lazyGroupsConnection, user.getEmail(), gSuiteSupportGroupEmailAddress);
|
|
|
|
ImmutableSetMultimap.Builder<String, Role> builder = new ImmutableSetMultimap.Builder<>();
|
|
|
|
ofy()
|
|
.load()
|
|
.type(RegistrarContact.class)
|
|
.filter("gaeUserId", user.getUserId())
|
|
.forEach(contact -> builder.put(contact.getParent().getName(), Role.OWNER));
|
|
if (isAdmin && !Strings.isNullOrEmpty(registryAdminClientId)) {
|
|
builder.put(registryAdminClientId, Role.OWNER);
|
|
}
|
|
|
|
if (isAdmin) {
|
|
// Admins have ADMIN access to all registrars, and OWNER access to all non-REAL registrars
|
|
ofy()
|
|
.load()
|
|
.type(Registrar.class)
|
|
.forEach(registrar -> {
|
|
if (!Registrar.Type.REAL.equals(registrar.getType())) {
|
|
builder.put(registrar.getClientId(), Role.OWNER);
|
|
}
|
|
builder.put(registrar.getClientId(), Role.ADMIN);
|
|
});
|
|
}
|
|
|
|
return builder.build();
|
|
}
|
|
|
|
/** Exception thrown when the current user doesn't have access to the requested Registrar. */
|
|
public static class RegistrarAccessDeniedException extends Exception {
|
|
RegistrarAccessDeniedException(String message) {
|
|
super(message);
|
|
}
|
|
}
|
|
}
|