mirror of
https://github.com/google/nomulus.git
synced 2025-08-25 18:43:46 +02:00
1227046bcb
In publishDomain, we load the subordinate hosts of the domain from datastore and compare its nameservers to them. For any nameserver that is in-baliwick, we call publishSubordinateHost on it and stage the A/AAAA records of the host for publication.
This is superior to the old approach where we use hostName.endsWith(domainName) to check if a nameserver is in-baliwick because it will mistake ns.another-example.tld as a subordinate host of example.tld. It is also better than checking hostName.endsWith("." + domainName), which will catch false positives as above, but falls short in a corner case where the nameserver has been deleted before its superordinate domain's record is updated. In that case, subordinateHosts.cotains(hostName) will be false but hostName.endsWith("." + domainName) will still be true.
Note that we still use the suffix check in filterGlueRecords because it is filtering on existing records from Cloud DNS. It is even advantageous to do so because if there were (and there shouldn't be if everything is consistent) any orphaned glue records (suffix matches to the domain, but not actually in its subordinate host list), they would be retained by the filter and therefore be deleted when the staged changes are committed.
Also fixed a few tests that should have failed had we checked subrodinate hosts....
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=184732005
|
||
|---|---|---|
| .. | ||
| backup | ||
| batch | ||
| beam | ||
| bigquery | ||
| builddefs | ||
| config | ||
| cron | ||
| dns | ||
| export | ||
| flows | ||
| groups | ||
| keyring | ||
| mapreduce/inputs | ||
| model | ||
| module | ||
| monitoring/whitebox | ||
| pricing | ||
| proxy | ||
| rdap | ||
| rde | ||
| reporting | ||
| request | ||
| security | ||
| server | ||
| storage/drive | ||
| testing | ||
| tldconfig/idn | ||
| tmch | ||
| tools | ||
| ui | ||
| util | ||
| whois | ||
| xjc | ||
| xml | ||