12 commits

Author	SHA1	Message	Date
mcilwain	f0c677b18b	Rename DNL and SMDRL "login" to "loginAndPassword" ... They are passed around in the format username:password, whereas just saying "login" implies it's just a username and not necessarily also a secret password. Putting password in the variable name makes it obvious what this is and reduces the likelihood of anyone ever logging it or otherwise using it inappropriately. Note that this does not require data migrations as the actual key used to store the data in KMS remains unchanged. This is a follow-up to [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=231253964	2019-01-28 16:15:04 -05:00
gbrodman	3cf26ff9b6	Fix various Error Prone errors that were found by the FOSS build ... Most common: - Unnecessary parentheses and operator precedence clarify (self-explanatory) - Reference equality--there were a few instances of using == or != improperly - Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to - Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable - String.split() having "surprising behavior" ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230971531	2019-01-28 16:05:09 -05:00
jianglai	aeedc427ad	Remove the ability to download service account credentials ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=224034254	2018-12-05 16:00:51 -05:00
jianglai	4416601a1d	Expose the functionality to decrypt given data using keyring ... This allows us to provide the keyring a blob of encrypted data and a key name, and have it decrypt it for us. Also fixed javadoc length in Keyring.java. It seems like it was using a 80-character length limit. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222995542	2018-12-03 19:05:59 -05:00
jianglai	886aa62d46	Expose encrypted data from the keyring ... This makes it possible to request the encrypted data directly in application code. It will be used to download service account credential during "nomulus login". ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222847905	2018-12-03 19:01:15 -05:00
mcilwain	32b3563126	Delete all Braintree code ... We never launched this, don't planning on launching it now anyway, and it's rotted over the past two years anyway. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202993577	2018-07-14 01:37:03 -04:00
mcilwain	ad73f3d167	Remove more unnecessary "throws" declarations ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201243722	2018-06-27 15:28:52 -04:00
mcilwain	30bfcf9c55	Remove more unused Truth8.assertThat() static imports in tests ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173562809	2017-11-07 17:22:56 -05:00
mcilwain	c0f8da0c6e	Switch from Guava Optionals to Java 8 Optionals ... This was a surprisingly involved change. Some of the difficulties included java.util.Optional purposely not being Serializable (so I had to move a few Optionals in mapreduce classes to @Nullable) and having to add the Truth Java8 extension library for assertion support. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171863777	2017-10-24 16:53:47 -04:00
guyben	bb70fcb66d	Refactor KmsKeyring and KmsUpdater to use a centralized serializer ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=151853998	2017-04-05 10:09:06 -04:00
shikhman	388dd1055e	Abstract KMS code with KmsConnection and create a fake KmsConnection ... This simplifies the tests for KmsKeyring and KmsUpdater. This is a followup to [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148496758	2017-02-27 11:30:45 -05:00
shikhman	be30ecdf66	Add Cloud KMS based secret storage ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=147791972	2017-02-17 12:22:12 -05:00