Commit graph

510 commits

Author SHA1 Message Date
mmuller
ebeded4c74 Use params from epp_session.js
Use bundled params instead of passing individual arguments through
epp_session.js.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136384801
2016-10-17 17:59:28 -04:00
mountford
f1ad34b12f Fix RDAP quirks uncovered during documentation
There's no reason not to allow a one-character search string when there are no wildcards. And the ROID validity pattern did not allow underscores, which was causing problems with our ROIDs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136256605
2016-10-17 17:53:18 -04:00
mcilwain
861fd60d2c Begin migration away from ReferenceUnions
It is important to get at least this one commit in before the public Nomulus
release so that none of our public users will have to go through this data
migration (although we will have to).

The migration strategy is as follows:

1. Dual-write to non-ReferenceUnion fields in addition to the current
ReferenceUnion fields in use, and add new indexes (this commit). Deploy.
2. Run the ResaveAllEppResourcesAction backfill [].
3. Switch all code over to using the new fields. Dual-write is still in effect,
except it is now copying over the values of the new fields to the old
fields. Switch over all BigQuery reporting scripts to use the new
fields. Deploy.
4. Remove all of the old code and indexes. Deploy.
5. (Optional, at our leisure) Re-run the ResaveAllEppResourcesAction backfill
[] to delete the old obsolete fields.

Note that this migration strategy is rollback-safe at every step -- new data is
not read until it has already been written out in the previous step, and old
data is not removed immediately following a step in which it was still being
read, so the previous step is safe to roll back to.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136196988
2016-10-14 17:52:01 -04:00
ctingue
3c36b6b928 Clean up billing MR work
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136196221
2016-10-14 17:47:46 -04:00
mmuller
84bbb9a7c0 Genericize "Contact Us" page
Parameterize integration, support and announcement email addresses and contact
phone number, make static parameters flow through the system in a consistent
manner.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136183813
2016-10-14 17:41:55 -04:00
ctingue
6a4088a8b6 Update Domain Registry maven dependencies
These are used to test our open-source build under the Kokoro Jenkins
environment ([]

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136182927
2016-10-14 17:40:24 -04:00
mountford
4b4a0cb1c1 Fix nomulus help anachronism.
list_hosts no longer differentiates between hosts by TLD.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136180967
2016-10-14 17:38:53 -04:00
mcilwain
6636e02d57 Clean up and consolidate some unused queues
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136170276
2016-10-14 17:37:21 -04:00
nickfelt
e6ba5687b1 Migrate writeLockTimeout field out of DnsQueue
This makes the usage of DnsQueue.create() safer, since we're no longer
forced to hardcode a copy of the @Config("dnsWriteLockTimeout") value
within that method.  That value is only needed for leaseTasks(), which
is only called in one place (ReadDnsQueueAction), so we can just pass
it in from that callsite.

Also removes an unused overload of leaseTasks() that allowed specifying
a tag, which is a feature we no longer need.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136162491
2016-10-14 17:00:33 -04:00
cgoldfeder
17475fe7e8 Remove spurious @Nullable
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136160050
2016-10-14 17:00:33 -04:00
ctingue
67da55536f Clean up misc Javadoc and deprecation warnings
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136156922
2016-10-14 17:00:33 -04:00
cgoldfeder
064026a4a5 Use an empty interval instead of null to signal no LRP
This removes the need for some null checks

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136146549
2016-10-14 17:00:33 -04:00
mountford
a033c03771 RDAP: Add comments with specific directions from ICANN
ICANN clarified some errors in the operational profile. Luckily, we had already guessed that that's how things should be.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136081694
2016-10-14 17:00:32 -04:00
jianglai
d355aebe01 Fix a few incorrect mentions of Nomulus
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136079699
2016-10-14 17:00:32 -04:00
mcilwain
3dbcee55bd Remove stale TODO on Javadoc for Registrar.PUBLICLY_VISIBLE_TYPES
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136078171
2016-10-14 17:00:32 -04:00
Wolfgang Meyers
94af94ddff Refactor some RDE import logic to be generic
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136076610
2016-10-14 17:00:26 -04:00
jianglai
71d7a382f3 Change all references to Domain Registry to Nomulus
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136068582
2016-10-14 16:58:07 -04:00
mcilwain
3b1be73b7d Remove fulfilled TODO to backfill RDAP indexes
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136062327
2016-10-14 16:58:07 -04:00
mcilwain
6a738557fb Use Dagger to @Inject DnsQueue everywhere that is feasible
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136062053
2016-10-14 16:58:07 -04:00
mcilwain
a13f6aded8 Remove stale TODO on setting GoogleCredential data
We simply don't need to do this.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136058076
2016-10-14 16:58:07 -04:00
mcilwain
7b9ce8e087 Inject RateLimiter in CloudDnsWriter
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136055927
2016-10-14 16:58:07 -04:00
cgoldfeder
70afce13fe Remove the fallback trid logic in DomainAllocateFlow.
There are no applications extant that predate the creationTrid field.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136047561
2016-10-14 16:58:07 -04:00
ctingue
4e0b6d36c4 Change lrpTldStates to Interval
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135957698
2016-10-14 16:58:07 -04:00
ctingue
dd9137fbd1 Rename LrpToken to LrpTokenEntity
This is to better distinguish between an LRP "token" (the string passed along in EPP) and the datastore entity that contains the token and all metadata.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135943480
2016-10-14 16:58:07 -04:00
nickfelt
a500812a91 Remove overly broad try-catch in BaseDomainCreateFlow.createFlowRepoId()
This bit Hans as described in
https://groups.google.com/d/topic/nomulus-discuss/o897-hRP_3c/discussion

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135842526
2016-10-14 16:58:07 -04:00
mcilwain
ffc0552c15 Fix "the the" typo in Javadoc
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135827263
2016-10-14 16:58:07 -04:00
cgoldfeder
c59227bb76 Remove useless createdRepoId from logging
It is no longer needed since we don't do log-replay and it's
annoying to support in the flat flows.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135805088
2016-10-14 16:58:07 -04:00
shikhman
f76bc70f91 Preserve test logs and test summary output for Kokoro CI runs
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135494972
2016-10-14 16:57:43 -04:00
cgoldfeder
cb8320ff40 Change @DoNotHydrate to work on fields, not types.
There was a circular reference when hydrating a domain with a
subordinate host, since the host references the domain. To fix
this, I redid @DoNotHydrate to be the way it should have been,
rather than the hack I had originally submitted. I also beefed
up the unit tests of the epp resource types to check for cycles.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135792416
2016-10-11 11:27:54 -04:00
cgoldfeder
049c636966 Add a missing verification to DomainApplicationUpdateFlow.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135712711
2016-10-11 11:27:53 -04:00
mcilwain
dfe0ba32cb Reduce Datastore load of delete prober data mapreduce
This eliminates the transactional load of ForeignKeyIndexes and
EppResourceIndexes, the latter of which was problematic because it is parented
on the EppResourceIndexBucket entity group, and can cause concurrent
modification exceptions on live code paths. By removing the transactional load
and only touching that entity group on the delete, the number of potential
concurrent modification exceptions is significantly reduced.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135706974
2016-10-11 11:27:49 -04:00
mountford
718da70b71 Add TLD extra flow logic for update
This CL implements the TLD-specific extra flow logic for updates, with tests, based on the static helper classes of the previous CL.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135683537
2016-10-11 11:27:48 -04:00
mcilwain
94c549d960 Delete obsoleted non-batched DNS refresh on host rename action
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135681285
2016-10-11 11:27:48 -04:00
nickfelt
ec64f4799c Fix javadoc on DomainApplicationIndex to reflect recent change
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135516642
2016-10-11 11:08:56 -04:00
mcilwain
f9fe25f00a Use "Nomulus" name in documentation
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135509458
2016-10-11 11:04:41 -04:00
mountford
b224a90a4c RDAP: Display truncation notice for large entity result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL (hopefully the last one) handles the fixes for entity (contact and registrar) searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135494283
2016-10-07 15:29:49 -04:00
mcilwain
503a10bbf8 Fix type inference error in RdapDomainSearchAction
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135482307
2016-10-07 15:29:49 -04:00
cgoldfeder
a09d48a4a5 Decentralize how registry phase checks are done in flows
Very few flows actually check the phase. Push the checks down to the leaf
flows so that we can remove the inherited code from ResourceFlow and replace
it with utility methods. In the process, document and test two places that
throw the exception but did not previously test it.

This introduces a temporary hack in BaseDomainCreateFlow that does something
specific for DomainApplicationCreateFlow. It will go away literally tomorrow
when I flatten that flow.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135480538
2016-10-07 15:29:48 -04:00
mountford
5c5499d598 RDAP: Display truncation notice for large nameserver result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL handles the fixes for nameserver searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135411617
2016-10-07 15:29:48 -04:00
mcilwain
43c67403fa Expurgate vestiges of superannuated flow hierarchy
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135407546
2016-10-07 15:29:48 -04:00
mountford
179bd22531 RDAP: Display truncation notice for large domain result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL handles the fixes for domain searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135407203
2016-10-07 15:29:48 -04:00
mcilwain
64426d3c7c Clarify the relationship between project ids in RegistryConfigs
This makes it clear that the non-production environment project ids are all
constructed by adding a suffix to the production environment project id, and
makes it slightly easier to configure it for a new environment (because there is
only one string to change instead of two).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135406763
2016-10-07 15:29:48 -04:00
mcilwain
d4e4333c2e Remove stray unused injected field in ContactDeleteFlow
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135406351
2016-10-07 15:29:48 -04:00
mmuller
129cbe8103 Make product name driven from config in the console
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135399007
2016-10-07 15:29:48 -04:00
mcilwain
e864fedab1 Remove trailing whitespace in files
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135386752
2016-10-07 15:29:47 -04:00
mcilwain
d02d30a4cd Use google.registry namespace for specifying RegistryConfig impl
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135386524
2016-10-07 15:29:47 -04:00
ctingue
0ae5d10632 Add metadata map to LrpToken
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135382828
2016-10-07 15:29:47 -04:00
ctingue
2cdd252919 Update Truth to v0.30
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135372219
2016-10-07 15:29:38 -04:00
ctingue
bba2fb92cc Fix TokenUtils Javadoc
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135361690
2016-10-07 14:40:01 -04:00
mcilwain
b65b855067 Always use the constructor to make Immutable Collection Builders
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135359669
2016-10-07 14:37:02 -04:00