This makes the code shorter, and the subclassing approach is deprecated.
Open-source note: Correspondence.from was added to Truth 0.43. (So was Correspondence.transforming, which I'm using occasionally instead.) Correspondence.formattingDiffsUsing was added in Truth 0.44.
END_PUBLIC
More information:
[]Tested:
TAP --sample ran all affected tests and none failed
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249913322
Our database is big enough now that it takes > 4 hours to run the RDE Staging mapreduce.
Retrying after 4 hours just causes a new mapreduce to run, interfering with the old one.
8 hours still means 3 attempts per 24 hour period (00:07, 08:07, 16:07) so we can catch up with the cursor if needed.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249829914
This makes it easy to experiment with new dependency versions or new plugins
without having to update the lock files, by adding "-PdisableDependencyLocking=true" to any gradle command.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249463575
This fixes linter errors when running gradle commands. However the investigation into the linter error revealed potential problematic behaviors with dependency resolution in Gradle. See the attached bug for details.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249256283
This fixes linter errors when running gradle commands. However the investigation into the linter error revealed potential problematic behaviors with dependency resolution in Gradle. See the attached bug for details.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249256283
I was testing this to see what the error was and I can't find one, so I assume it must have just been fixed at some point
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248551972
Per further discussion on b/130533696, we've decided to increase these so
tenants can have greater resilience to an outage in our DNS servers.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248546853
Most of the changes in this CL were made manually.
I've tried to preserve all information (and of course behavior!), but the format and grammar of the messages does change. For example before-and-after messages, see the LSC doc.
In some of the CLs in this round (e.g., jscomp), I don't know a lot about the domain being tested, and the assertions are complex, so please let me know if my new phrasing is wrong or confusing.
Thanks again for your patience with all the Truth changes lately.
END_PUBLIC
More information:
[]
Tested:
TAP for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248543745
It only had one subclass and it unnecessarily complicates things. It originally existed because DomainBase was abstract and could have multiple implementations but that is no longer the case.
This will also help with []
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248529389
To support the open source community, which may want to use different analytics services, we implement a soy template for analytics services that:
1) Does not require users to implement Google Analytics
2) Allows users to add their own analytics code to `Analytics.soy`
3) Gives users the flexibility to pass as much or as little static configuration to their custom analytics code as needed.
4) Ensures that users can merge upstream Nomulus code in the future without having to delete their custom analytics implementations
5) Does not allow code to be injected from configuration, which Soy as a framework actively discourages.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248340081
Also removed the rdapWhoisServer value, as it's just null and will likely stay that way (it isn't mentioned in the RDAP response profile)
If it'll ever become required, we can add it back.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247643981
This CL made the following changes to achieve the purpose:
1. Modified HttpProxy.java to generate a file containing Maven
coordinates for all requested JAR files. This is to replace
Gradle task "generateMavenCoordinateForDependency" which served
for the same purpose before. The reason is during the course
of the build, Gradle may request some POM file of a artifact
for some reason but it doesn't actually need the JAR file.
However, task "generateMavenCoordinateForDependency" cannot
identify this use case so it added more JARs to the dependency
which are not necessary and are not consistent with what we
get from HttpProxy.java. Going forward, we will use HttpProxy.java
as the single source to provide dependency.
2. Updated update_deps_metadata.py to retrieve *-sources.jar for each
dependency for obvious reason.
3. Improved update_dependency.sh by removing 1 unnecessary build.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247607871
I have resaved all the tokens and verified in BigQuery that there are no
remaining null tokenTypes.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247425132
actual() is being removed.
More information:
[]
Tested:
TAP --sample ran all affected tests and none failed
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247415370
We currently create it from injected arguments, and pass it to every function.
Instead, we just create a provider for it and inject it where needed.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247072517
Currently we try to reimplemnet the same behavior of the existing code as much
as possible.
We only fix issues that go against the RFC7483, but we don't yet update the
code to follow the latest (15feb19) RDAP Response Profile. That will require a
much bigger change especially for the test files, so it'll wait for a followup
CL.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246948018
The TestServerRule object is shared between retries in the same test,
so the testServer object constructed in TestServerRule's constructor
will be shared as well. This should be the reason why the test retry
carries over some state. (The log in the test proves that the
testServer object is shared because it listens to the same port in
all retries, which should not happen if its constructor is invoked
every time. You can find multiple "TestServerRule is listening on:
[]in this test
[]
So, this CL delayed the construction to rule.before() method which is
invoked before every retry.(You can see each retry has a test server
listening to different port and the error is "It differed by <16> pixels."
for all attempts instead of not clickable button []
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246904446
Make root build.gradle easier to read:
- Moved appengine war-assembly into separate script
- Moved java static analysis configs to separate script,
for easier sharing with buildSrc folder.
Update Gradle config in the buildSrc folder:
- Applied static analysis, and cleaned up a few style and
dependency lint errors.
- Added dependency locks
- Set up Google java format enforcement (Spotless)
since this is new code.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246858172
Bazel's GenTestRules does not support the "timeout" parameter, introduced in []
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246830344
Check the timing (that is, whether or not we're in a promotion), the allowed registrar client IDs, and the allowed TLDs.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246824080
The two behave identically, and containsAllOf is being removed.
More information:
[]
Tested:
TAP --sample for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246791491
This CL looks good? Just LGTM and Approve it!
This CL doesn't look good? File a bug using []
What else can you do?
* Suggest a fix on the CL ([]
* Revert this CL, by replying "REVERT: <provide reason>".
* Revert this CL and not get a CL that cleans up this file in the future by replying "BLACKLIST: <provide reason>". This action is not reversible!
This CL was automatically generated by ATTT ([] using CL Shepherd ([] Please contact [] for questions.
//third_party/java_src/gtld/javatests/google/registry/model:registry/label/GenrulePremiumListTest: We're adjusting the test target timeout because it has a 1.248050 percent time out rate based on last week's (2019-04-27 - 2019-05-04) tap postsubmit running statistics. Its original timeout_sec is 60, and we're adjusting it to moderate, which is 300 seconds.
Some detailed statistics for the target:
Num of invocation: 641
Num of passed invocations: 633
Num of timeout invocations: 8
****** Stats for passing runs ******
Min run time in secs: 14
Max run time in secs: 57
Mean run time in secs: 28.955766
Sd run time in secs: 9.104767
#codehealth
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246791200
The overload that accepts a description generally produces better failure messages:
- The first line of the message it produces is something like: "value of: myProto.getResponse()" (where "getResponse()" is taken from the provided description)
- The last line of the message it produces is something like: "myProto was: response: query was throttled" (the full value of myProto)
- And the existing text goes in between.
Additional motivation: We are deleting the no-arg overload externally (and probably internally thereafter).
Tested:
TAP --sample ran all affected tests and none failed
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246582329
This will populate the token type to be SINGLE_USE for existing tokens that
don't have a type.
Modeled after the ResaveEntitiesCommand, but modified so that we load all AllocationTokens (rather than having to provide a list of entity IDs on the command line)
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246572756
The two behave identically, and containsAllIn is being removed.
More information:
[]
Tested:
TAP --sample for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246565417
They behave identically, and the old names are being removed.
Open-source note: The new methods are available in Truth as of version 0.44.
END_PUBLIC
More information:
[]
Tested:
TAP --sample ran all affected tests and none failed
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246550001
Also upgraded Guava to 27.1-jre and truth java8 extension to v0.44.
Also removed lockfiles no longer in use in Gradle 5.4.
Follow up change will update bazel dependencies.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246515393
Also updated the docker rules to be compatible with the new version of bazel,
and updated the proxy base image to the latest Java 8 version.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246509816
Overriding getter methods to change values is a bit overkill when these values
are static (don't change based on internal state).
Just setting them in the base class' constructor is simpler.
Also, we can read the PATH of an Action based on the Annotation instead
returning it manually for each Action.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246135754
Part of the attempt to remove or suppress warnings for deprecated
API use, which will make the Gradle project usable with Intellij.
Currently in the Intellij/Gradle setup, deprecation warnings cause
Intellij build process to fail. Passing -Werror:none flags to javac\
does not have any effect.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246135737
We need this as a precursor to running refreshDnsForAllDomains to change our
TTLs from 3 minutes to an hour (see the associated bug for details).
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246011747
(The exact change is slightly different in some cases, like when using custom subjects or check(), but it's always a migration from named(...) to [assert]WithMessage(...).)
named(...) is being removed.
This CL may slightly modify the failure messages produced, but all the old information will still be present.
More information:
[]
Tested:
TAP --sample for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245762634
For example:
assertThat(actual().foo()).isEqualTo(expected);
becomes:
check("foo()").that(actual().foo()).isEqualTo(expected);
More information:
[]
Tested:
TAP --sample for global presubmit queue
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245750144
This makes it possible to pull the gradle binary from a trusted source when building the release artifacts.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245450562
