9 commits

Author	SHA1	Message	Date
mcilwain	7dc224627f	Automatically refactor more exception testing to use new JUnit rules ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178911894	2017-12-27 10:42:36 -05:00
mcilwain	03c782f38e	Replace ExceptionRule with ExpectedException ... This is in preparation for running the automatic refactoring script that will replace all ExpectedExceptions with use of JUnit 4.13's assertThrows/ expectThrows. Note that I have recorded the callsites of assertions about EppExceptions being marshallable and will edit those specific assertions back in after running the automatic refactoring script (which do not understand these). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178812403	2017-12-13 12:43:45 -05:00
mcilwain	e2db3f914e	Clean up some code quality issues ... This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177182945	2017-12-01 22:14:06 -05:00
mcilwain	2aa897e698	Remove unnecessary generic type arguments ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=175155365	2017-11-21 18:17:31 -05:00
mcilwain	eed2e0c45f	Remove unnecessary explicit generic type declarations ... They can be inferred correctly even in Java 7, and display as compiler warnings in IntelliJ. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173451087	2017-11-07 17:11:29 -05:00
mcilwain	f59c3daf6d	Remove unused Truth8.assertThat() imports in tests ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173423036	2017-11-07 17:01:19 -05:00
mcilwain	c0f8da0c6e	Switch from Guava Optionals to Java 8 Optionals ... This was a surprisingly involved change. Some of the difficulties included java.util.Optional purposely not being Serializable (so I had to move a few Optionals in mapreduce classes to @Nullable) and having to add the Truth Java8 extension library for assertion support. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171863777	2017-10-24 16:53:47 -04:00
mcilwain	d2ca4b7234	Refactor main loop of MapreduceEntityCleanupAction ... This also tightens up some error-checking conditions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149552065	2017-03-13 10:38:21 -04:00
mountford	5d4287a375	Add mapreduce cleanup action ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149432516	2017-03-13 10:24:57 -04:00