13 commits

Author	SHA1	Message	Date
mcilwain	ad73f3d167	Remove more unnecessary "throws" declarations ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201243722	2018-06-27 15:28:52 -04:00
mcilwain	5d80f124ca	Remove unnecessary "throws" declarations ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201058582	2018-06-18 18:17:56 -04:00
cushon	606b470cd0	Merge JUnitBackport's expectThrows into assertThrows ... More information: https://github.com/junit-team/junit5/issues/531 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=187034408	2018-03-06 18:56:15 -05:00
mcilwain	16a1d6d196	Refactor the last usages of ExpectedException to assert/expectThrows ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179095403	2017-12-27 10:56:36 -05:00
mcilwain	03c782f38e	Replace ExceptionRule with ExpectedException ... This is in preparation for running the automatic refactoring script that will replace all ExpectedExceptions with use of JUnit 4.13's assertThrows/ expectThrows. Note that I have recorded the callsites of assertions about EppExceptions being marshallable and will edit those specific assertions back in after running the automatic refactoring script (which do not understand these). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178812403	2017-12-13 12:43:45 -05:00
mcilwain	b825a2b5a8	Get rid of custom ExceptionRule methods ... The only remaining methods on ExceptionRule after this are methods that also exist on ExpectedException, which will allow us to, in the next CL, swap out the one for the other and then run the automated refactoring to turn it all into assertThrows/expectThrows. Note that there were some assertions about root causes that couldn't easily be turned into ExpectedException invocations, so I simply converted them directly to usages of assertThrows/expectThrows. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178623431	2017-12-13 12:43:45 -05:00
guyben	b8970bfe1b	Rename all testdata loading files to conform to a single naming scheme ... The scheme is: - loadBytes: returns a ByteSource of the data - loadFile: returns a string using UTF8 encoding, optionally applying substitutions ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177606406	2017-12-01 22:14:06 -05:00
mcilwain	2aa897e698	Remove unnecessary generic type arguments ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=175155365	2017-11-21 18:17:31 -05:00
mcilwain	f59c3daf6d	Remove unused Truth8.assertThat() imports in tests ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173423036	2017-11-07 17:01:19 -05:00
mcilwain	c0f8da0c6e	Switch from Guava Optionals to Java 8 Optionals ... This was a surprisingly involved change. Some of the difficulties included java.util.Optional purposely not being Serializable (so I had to move a few Optionals in mapreduce classes to @Nullable) and having to add the Truth Java8 extension library for assertion support. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171863777	2017-10-24 16:53:47 -04:00
mmuller	b70f57b7c7	Update copyright year on all license headers ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146111211	2017-02-02 16:27:22 -05:00
mcilwain	eaec03e670	Move ConfigModule and LocalTestConfig into RegistryConfig ... This is the final preparatory step necessary in order to load and load configuration from YAML in a static context and then provide it either via Dagger (using ConfigModule) or through RegistryConfig's existing static functions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=143819983	2017-01-09 12:01:09 -05:00
mcilwain	e46fdf9a87	Fix missing RDE imports files in Nomulus ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=141942879	2016-12-13 18:01:39 -05:00