5 commits

Author	SHA1	Message	Date
mcilwain	b46a6b6d55	Fix some statically detected code issues ... This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244182539	2019-04-22 12:54:34 -04:00
guyben	4097dae3b2	Only inject @Parameter-created variables in the Action itself ... Icann reports have 3 parameter-provided injections: - yearMonth - subdir - reportType We move all of them away from the "inner classes" and only @Inject them in the Actions themselves. This has 2 benefits: - it's much clearer what all the parameter inputs of the Actions are - the "inner injected classes" don't assume anything about the Action that uses them - they will work just as well for JSON actions as for "regular" actions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=233625765	2019-02-13 16:07:45 -05:00
jianglai	84c3544097	Change SendEmailService to an instance field. ... This allows us to inject it with Dagger and avoid using InjectRule to set it in unit tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217571475	2018-10-22 18:43:18 -04:00
weiminyu	961e5cc7c7	Use @DefaultCredential for Cloud API access in GAE ... This change completes the switch to @DefaultCredential for all use cases in GAE. Impacted modules: - IcannReporting - CreateCdnsTld command - LoadSnapshot command. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213511730	2018-09-20 11:19:36 -04:00
larryruili	74ced1e907	Refactor ICANN reporting and billing into common package ... This moves the default yearMonth logic into a common ReportingModule, rather than the coarse-scoped BackendModule, which may not want the default parameter extraction logic, as well as moving the 'yearMonth' parameter constant to the common package it's used in. This also provides a basis for future consolidation of the ReportingEmailUtils and BillingEmailUtils classes, which have modest overlap. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=183130311	2018-02-01 21:56:06 -05:00

Renamed from java/google/registry/reporting/IcannReportingModule.java (Browse further)