5 commits

Author	SHA1	Message	Date
mcilwain	ed0670b614	Remove unnecessary type specifications ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179585680	2017-12-27 11:23:03 -05:00
mcilwain	9157930983	Automatically refactor more exception testing to use new JUnit rules ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179072309	2017-12-27 10:50:20 -05:00
mcilwain	b825a2b5a8	Get rid of custom ExceptionRule methods ... The only remaining methods on ExceptionRule after this are methods that also exist on ExpectedException, which will allow us to, in the next CL, swap out the one for the other and then run the automated refactoring to turn it all into assertThrows/expectThrows. Note that there were some assertions about root causes that couldn't easily be turned into ExpectedException invocations, so I simply converted them directly to usages of assertThrows/expectThrows. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178623431	2017-12-13 12:43:45 -05:00
mcilwain	d536cef20f	Make Registrar load methods return Optionals instead of Nullables ... This makes the code more understandable from callsites, and also forces users of this function to deal with the situation where the registrar with a given client ID might not be present (it was previously silently NPEing from some of the callsites). This also adds a test helper method loadRegistrar(clientId) that retains the old functionality for terseness in tests. It also fixes some instances of using the load method with the wrong cachedness -- some uses in high- traffic situations (WHOIS) that should have caching, but also low-traffic reporting that don't benefit from caching so might as well always be current. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=162990468	2017-08-01 16:58:59 -04:00
bbilbo	9688638c75	Use History Entry type for flows in VerifyOteServlet ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=161855429	2017-08-01 16:24:55 -04:00