11 commits

Author	SHA1	Message	Date
mcilwain	ed0670b614	Remove unnecessary type specifications ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179585680	2017-12-27 11:23:03 -05:00
mcilwain	fbe11ff33c	Use method references instead of lambdas when possible ... The assertThrows/expectThrows refactoring script does not use method references, apparently. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179089048	2017-12-27 10:55:03 -05:00
mcilwain	7dc224627f	Automatically refactor more exception testing to use new JUnit rules ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178911894	2017-12-27 10:42:36 -05:00
mcilwain	03c782f38e	Replace ExceptionRule with ExpectedException ... This is in preparation for running the automatic refactoring script that will replace all ExpectedExceptions with use of JUnit 4.13's assertThrows/ expectThrows. Note that I have recorded the callsites of assertions about EppExceptions being marshallable and will edit those specific assertions back in after running the automatic refactoring script (which do not understand these). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178812403	2017-12-13 12:43:45 -05:00
mcilwain	b825a2b5a8	Get rid of custom ExceptionRule methods ... The only remaining methods on ExceptionRule after this are methods that also exist on ExpectedException, which will allow us to, in the next CL, swap out the one for the other and then run the automated refactoring to turn it all into assertThrows/expectThrows. Note that there were some assertions about root causes that couldn't easily be turned into ExpectedException invocations, so I simply converted them directly to usages of assertThrows/expectThrows. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178623431	2017-12-13 12:43:45 -05:00
mcilwain	30bfcf9c55	Remove more unused Truth8.assertThat() static imports in tests ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173562809	2017-11-07 17:22:56 -05:00
mcilwain	c0f8da0c6e	Switch from Guava Optionals to Java 8 Optionals ... This was a surprisingly involved change. Some of the difficulties included java.util.Optional purposely not being Serializable (so I had to move a few Optionals in mapreduce classes to @Nullable) and having to add the Truth Java8 extension library for assertion support. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171863777	2017-10-24 16:53:47 -04:00
mountford	d35be27b65	Remove some unnecessary uses of MockitoJUnitRunner, which is discouraged ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=153589104	2017-04-26 10:42:43 -04:00
mcilwain	636da9f7f0	Convert yet more configuration options to YAML ... With a particular focus on custom logic and caching. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146258446	2017-02-02 17:05:28 -05:00
mmuller	b70f57b7c7	Update copyright year on all license headers ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146111211	2017-02-02 16:27:22 -05:00
jianglai	4fed3a9ae6	Daggerize ExportSnapshotServlet and CheckSnapshotServlet ... Eradicate the last remnants of un-injectable servlets! ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145598002	2017-01-30 15:03:53 -05:00