Lai Jiang
6e317a090b
Remove unnecessary provider method ( #113 )
...
* Remove unnecessary provide method
This provider is not used. Instead, depending on if the login is performed on
[a remote machine or not](8bdc77501f/core/src/main/java/google/registry/tools/LoginCommand.java (L43)
),
the instance is created directly in the command.
* Remove unused imports
2019-06-18 15:55:33 -04:00
Shicong Huang
f1f9a9aa56
Merge pull request #105 from hstonec/deploy-beam-from-gcb
...
Add a CloudBuild task to deploy Beam pipeline
2019-06-18 15:34:28 -04:00
Shicong Huang
32a75ead01
Consolidate testcontainer used by WebDriver test ( #112 )
...
* Consolidate testcontainer used by WebDriver test
Previously, we hard coded the version of the docker image for
provisioning Chrome browser and WebDriver server because the
version of the Chrome browser has to match the version of
the webdriver client, otherwise the screenshot test will fail.
Changing to use BrowserWebDriverContainer can delegate the match
to the library itself because it chooses the correct docker image
version based on the WebDriver version on our classpath.
* Increase maxColorDiff to 20
This is to supress the test flakness after switching to use
BrowserWebDriverContainer to provision browser and webdriver
service.
2019-06-18 11:51:55 -04:00
gbrodman
475ef29a80
Merge pull request #87 from google/gb/karma-testing
...
Move the Javascript tests to use Jasmine/Karma
2019-06-18 11:09:29 -04:00
Shicong Huang
ece6ae1d78
Add a CloudBuild task to deploy Beam pipeline
2019-06-18 10:48:41 -04:00
Gus Brodman
55a82425e7
Respond to CR
2019-06-17 12:04:43 -04:00
Gus Brodman
5927ea9fd9
Move the Javascript tests to use Jasmine/Karma
2019-06-17 11:44:52 -04:00
Gus Brodman
ab3d83dabe
Filter out non-published domains in Spec11 emails
2019-06-14 14:34:12 -04:00
gbrodman
c766ec6322
Merge branch 'master' into gb/validateEmails
2019-06-14 10:44:23 -04:00
gbrodman
2aab7ce519
Merge branch 'master' into gb/upgradeJCommander
2019-06-13 18:18:55 -04:00
Lai Jiang
e17986dfa4
Remove Bazel build ( #94 )
...
* Remove bazel build
Also updated the build badge to reflect internal build status.
2019-06-13 18:15:33 -04:00
Gus Brodman
aab6ab3c1d
Add more tests in RegistrarTest
2019-06-13 18:04:57 -04:00
Gus Brodman
111b3f15b2
Validate provided email addresses when creating a registrar
2019-06-13 13:13:06 -04:00
Gus Brodman
65dfebf99d
Upgrade jcommander dep
2019-06-13 13:04:48 -04:00
Gus Brodman
9a59cd587e
More moving of hello.xml files -- they're all the same
2019-06-13 11:52:04 -04:00
Gus Brodman
fdf85b507c
Move hello.xml and don't use project.ext.foo
2019-06-13 10:14:50 -04:00
Gus Brodman
38cfc9f693
Refactor to be more in line with a standard Gradle project structure
2019-06-13 09:41:11 -04:00