7 commits

Author	SHA1	Message	Date
nickfelt	16832323d0	Make ListObjectsAction return 200 when sending JSON error ... This fixes a bug in the interaction between ListObjectsAction and ListObjectsCommand/AppEngineConnection. ListObjectsAction was returning HTTP status code 400 when it caught an IAE, but also attempting to return a JSON response payload of {"status": "error", "error": "<exception message>"}. However, AppEngineConnection treats any HTTP error response as more like a crash on the server side - it attempts to scrape the error message out of the autogenerated HTML that AppEngine produces for uncaught exceptions, and throws an exception, killing ListObjectsCommand before it can extract the JSON which contains the nicer error (that stating the missing field, etc versus just "400 Bad Request"). The fix is just to have ListObjectsAction return a 200 and the error message so that ListObjectsCommand can correctly handle it. I also de-scoped the catch to only catching IAE, since catching Exception was overbroad, and the only "expected" exception to be thrown is an IAE from the checkArgument() that tests if the requested fields all exist. Any other kinds of exceptions should actually just bubble up and kill the action, and get the regular AppEngineConnection error treatment. I also added "billingId" as an alias for "billingIdentifier", parallel to clientId/clientIdentifier, since that's why I came across this issue in the first place. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148248834	2017-02-27 11:10:37 -05:00
mmuller	b70f57b7c7	Update copyright year on all license headers ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146111211	2017-02-02 16:27:22 -05:00
mcilwain	5f32d1bbeb	Correctly set HTTP error status codes when list objects fails ... This makes the associated nomulus tool commands correctly return error exit codes when the server-side component fails. This improves scriptability. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=140543216	2016-12-06 11:52:46 -05:00
shikhman	f76bc70f91	Preserve test logs and test summary output for Kokoro CI runs ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135494972	2016-10-14 16:57:43 -04:00
mcilwain	aa2f283f7c	Convert entire project to strict lexicographical import sort ordering ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=127234970	2016-07-13 15:59:53 -04:00
Michael Muller	c458c05801	Rename Java packages to use the .google TLD ... The dark lord Gosling designed the Java package naming system so that ownership flows from the DNS system. Since we own the domain name registry.google, it seems only appropriate that we should use google.registry as our package name.	2016-05-13 20:04:42 -04:00
Justine Tunney	5012893c1d	mv com/google/domain/registry google/registry ... This change renames directories in preparation for the great package rename. The repository is now in a broken state because the code itself hasn't been updated. However this should ensure that git correctly preserves history for each file.	2016-05-13 18:55:08 -04:00

Renamed from javatests/com/google/domain/registry/tools/server/ListReservedListsActionTest.java (Browse further)