diff --git a/java/google/registry/repositories.bzl b/java/google/registry/repositories.bzl index 2c6e6fb5a..22145808b 100644 --- a/java/google/registry/repositories.bzl +++ b/java/google/registry/repositories.bzl @@ -1458,10 +1458,10 @@ def com_google_re2j(): def com_google_template_soy(): java_import_external( name = "com_google_template_soy", - jar_sha256 = "2952b430323a01070d73c7767e34c4030355b9e60c14b5165bebf69b2f6ad927", + jar_sha256 = "3c4e61234e9ee9f79411da997e23b201bcf281255469c76d162dac07a67dbb78", jar_urls = [ - "http://repo1.maven.org/maven2/com/google/template/soy/2018-01-03/soy-2018-01-03.jar", - "http://central.maven.org/maven2/com/google/template/soy/2018-01-03/soy-2018-01-03.jar", + "http://repo1.maven.org/maven2/com/google/template/soy/2017-06-22/soy-2017-06-22.jar", + "http://central.maven.org/maven2/com/google/template/soy/2017-06-22/soy-2017-06-22.jar", ], deps = [ "@args4j", diff --git a/java/google/registry/tools/soy/ContactCreate.soy b/java/google/registry/tools/soy/ContactCreate.soy index 3fb402e1d..547438189 100644 --- a/java/google/registry/tools/soy/ContactCreate.soy +++ b/java/google/registry/tools/soy/ContactCreate.soy @@ -48,9 +48,9 @@ {/if} {if $street} - {for $s in $street} + {foreach $s in $street} {$s} - {/for} + {/foreach} {/if} {if $city} {$city} diff --git a/java/google/registry/tools/soy/DomainAllocate.soy b/java/google/registry/tools/soy/DomainAllocate.soy index 902db4bb5..7da1f590c 100644 --- a/java/google/registry/tools/soy/DomainAllocate.soy +++ b/java/google/registry/tools/soy/DomainAllocate.soy @@ -39,15 +39,15 @@ {$period} {if isNonnull($nameservers) and length($nameservers) > 0} - {for $nameserver in $nameservers} + {foreach $nameserver in $nameservers} {$nameserver} - {/for} + {/foreach} {/if} {$registrant} - {for $type in keys($contacts)} + {foreach $type in keys($contacts)} {$contacts[$type]} - {/for} + {/foreach} {$authInfo} @@ -70,14 +70,14 @@ {if isNonnull($dsRecords) and length($dsRecords) > 0} - {for $dsRecord in $dsRecords} + {foreach $dsRecord in $dsRecords} {$dsRecord['keyTag']} {$dsRecord['algorithm']} {$dsRecord['digestType']} {$dsRecord['digest']} - {/for} + {/foreach} {/if} diff --git a/java/google/registry/tools/soy/DomainCheck.soy b/java/google/registry/tools/soy/DomainCheck.soy index 3520cf549..877f50a8f 100644 --- a/java/google/registry/tools/soy/DomainCheck.soy +++ b/java/google/registry/tools/soy/DomainCheck.soy @@ -24,9 +24,9 @@ - {for $d in $domainNames} + {foreach $d in $domainNames} {$d} - {/for} + {/foreach} RegistryTool diff --git a/java/google/registry/tools/soy/DomainCheckClaims.soy b/java/google/registry/tools/soy/DomainCheckClaims.soy index a8952cea8..de49617a0 100644 --- a/java/google/registry/tools/soy/DomainCheckClaims.soy +++ b/java/google/registry/tools/soy/DomainCheckClaims.soy @@ -24,9 +24,9 @@ - {for $d in $domainNames} + {foreach $d in $domainNames} {$d} - {/for} + {/foreach} diff --git a/java/google/registry/tools/soy/DomainCheckFee.soy b/java/google/registry/tools/soy/DomainCheckFee.soy index 06e0eb636..5d1f33ea7 100644 --- a/java/google/registry/tools/soy/DomainCheckFee.soy +++ b/java/google/registry/tools/soy/DomainCheckFee.soy @@ -24,20 +24,20 @@ - {for $d in $domainNames} + {foreach $d in $domainNames} {$d} - {/for} + {/foreach} - {for $d in $domainNames} + {foreach $d in $domainNames} {$d} create 1 - {/for} + {/foreach} RegistryTool diff --git a/java/google/registry/tools/soy/DomainCreate.soy b/java/google/registry/tools/soy/DomainCreate.soy index 2499a960b..04774197a 100644 --- a/java/google/registry/tools/soy/DomainCreate.soy +++ b/java/google/registry/tools/soy/DomainCreate.soy @@ -36,18 +36,18 @@ {/if} {if length($nameservers) > 0} - {for $s in $nameservers} + {foreach $s in $nameservers} {$s} - {/for} + {/foreach} {/if} {$registrant} - {for $admin in $admins} + {foreach $admin in $admins} {$admin} - {/for} - {for $tech in $techs} + {/foreach} + {foreach $tech in $techs} {$tech} - {/for} + {/foreach} {$password} diff --git a/java/google/registry/tools/soy/DomainUpdate.soy b/java/google/registry/tools/soy/DomainUpdate.soy index c5cc24185..5053751a9 100644 --- a/java/google/registry/tools/soy/DomainUpdate.soy +++ b/java/google/registry/tools/soy/DomainUpdate.soy @@ -42,40 +42,40 @@ {if length($addNameservers) > 0} - {for $s in $addNameservers} + {foreach $s in $addNameservers} {$s} - {/for} + {/foreach} {/if} - {for $admin in $addAdmins} + {foreach $admin in $addAdmins} {$admin} - {/for} - {for $tech in $addTechs} + {/foreach} + {foreach $tech in $addTechs} {$tech} - {/for} - {for $status in $addStatuses} + {/foreach} + {foreach $status in $addStatuses} - {/for} + {/foreach} {/if} {if $remove} {if length($removeNameservers) > 0} - {for $s in $removeNameservers} + {foreach $s in $removeNameservers} {$s} - {/for} + {/foreach} {/if} - {for $admin in $removeAdmins} + {foreach $admin in $removeAdmins} {$admin} - {/for} - {for $tech in $removeTechs} + {/foreach} + {foreach $tech in $removeTechs} {$tech} - {/for} - {for $status in $removeStatuses} + {/foreach} + {foreach $status in $removeStatuses} - {/for} + {/foreach} {/if} {if $change} diff --git a/java/google/registry/tools/soy/HostCreate.soy b/java/google/registry/tools/soy/HostCreate.soy index 1e68db2b0..26d97a3d6 100644 --- a/java/google/registry/tools/soy/HostCreate.soy +++ b/java/google/registry/tools/soy/HostCreate.soy @@ -28,14 +28,14 @@ {$hostname} {if $ipv4addresses} - {for $ipv4 in $ipv4addresses} + {foreach $ipv4 in $ipv4addresses} {$ipv4} - {/for} + {/foreach} {/if} {if $ipv6addresses} - {for $ipv6 in $ipv6addresses} + {foreach $ipv6 in $ipv6addresses} {$ipv6} - {/for} + {/foreach} {/if} diff --git a/java/google/registry/tools/soy/RemoveIpAddress.soy b/java/google/registry/tools/soy/RemoveIpAddress.soy index 572008fa7..efa3a17f0 100644 --- a/java/google/registry/tools/soy/RemoveIpAddress.soy +++ b/java/google/registry/tools/soy/RemoveIpAddress.soy @@ -28,11 +28,11 @@ {$name} - {for $ip in $ipAddresses} + {foreach $ip in $ipAddresses} {$ip['address']} - {/for} + {/foreach} diff --git a/java/google/registry/tools/soy/UniformRapidSuspension.soy b/java/google/registry/tools/soy/UniformRapidSuspension.soy index 153c2fde2..62023d192 100644 --- a/java/google/registry/tools/soy/UniformRapidSuspension.soy +++ b/java/google/registry/tools/soy/UniformRapidSuspension.soy @@ -34,26 +34,26 @@ {if length($hostsToAdd) > 0} - {for $ha in $hostsToAdd} + {foreach $ha in $hostsToAdd} {$ha} - {/for} + {/foreach} {/if} - {for $la in $locksToApply} + {foreach $la in $locksToApply} - {/for} + {/foreach} {if length($hostsToRemove) > 0} - {for $hr in $hostsToRemove} + {foreach $hr in $hostsToRemove} {$hr} - {/for} + {/foreach} {/if} - {for $lr in $locksToRemove} + {foreach $lr in $locksToRemove} - {/for} + {/foreach} @@ -64,14 +64,14 @@ {if length($newDsData) > 0} - {for $ds in $newDsData} + {foreach $ds in $newDsData} {$ds.keyTag} {$ds.alg} {$ds.digestType} {$ds.digest} - {/for} + {/foreach} {/if} diff --git a/java/google/registry/tools/soy/UpdateServerLocks.soy b/java/google/registry/tools/soy/UpdateServerLocks.soy index e6c2888df..7c348c5bb 100644 --- a/java/google/registry/tools/soy/UpdateServerLocks.soy +++ b/java/google/registry/tools/soy/UpdateServerLocks.soy @@ -31,14 +31,14 @@ xmlns:domain="urn:ietf:params:xml:ns:domain-1.0"> {$domainName} - {for $a in $locksToApply} + {foreach $a in $locksToApply} - {/for} + {/foreach} - {for $r in $locksToRemove} + {foreach $r in $locksToRemove} - {/for} + {/foreach} diff --git a/java/google/registry/ui/soy/BUILD b/java/google/registry/ui/soy/BUILD index 0d471b40a..56db14d4b 100644 --- a/java/google/registry/ui/soy/BUILD +++ b/java/google/registry/ui/soy/BUILD @@ -10,9 +10,6 @@ closure_js_template_library( name = "soy", srcs = glob(["*.soy"]), globals = "//java/google/registry/ui:globals.txt", - # TODO: remove this when upgrading rules closure. This is only necessary because - # our version of soy is newer than what rules closure expects - should_generate_js_doc = False, ) closure_java_template_library( diff --git a/java/google/registry/ui/soy/Forms.soy b/java/google/registry/ui/soy/Forms.soy index a3c364b93..053cf51a2 100644 --- a/java/google/registry/ui/soy/Forms.soy +++ b/java/google/registry/ui/soy/Forms.soy @@ -244,11 +244,11 @@ name="{$name}" class="{css('kd-button')} {css('reg-select')}" {if $readonly}disabled{/if}> - {for $option in $options} + {foreach $option in $options} - {/for} + {/foreach} @@ -263,12 +263,12 @@ {template .inputRadioWithValue} - {for $value in $values} + {foreach $value in $values} - {/for} + {/foreach} {/template} @@ -309,13 +309,13 @@
    - {for $item in $items} + {foreach $item in $items}
  • {$item} - {/for} + {/foreach}
{/template} diff --git a/java/google/registry/ui/soy/registrar/BUILD b/java/google/registry/ui/soy/registrar/BUILD index d87cd3fd7..f51b1ed6a 100644 --- a/java/google/registry/ui/soy/registrar/BUILD +++ b/java/google/registry/ui/soy/registrar/BUILD @@ -11,9 +11,6 @@ closure_js_template_library( srcs = glob(["*.soy"]), data = ["//java/google/registry/ui/css:registrar_raw"], globals = "//java/google/registry/ui:globals.txt", - # TODO: remove this when upgrading rules closure. This is only necessary because - # our version of soy is newer than what rules closure expects - should_generate_js_doc = False, deps = ["//java/google/registry/ui/soy"], ) diff --git a/java/google/registry/ui/soy/registrar/Contact.soy b/java/google/registry/ui/soy/registrar/Contact.soy index 9b41fcab6..fa2c3c6f3 100644 --- a/java/google/registry/ui/soy/registrar/Contact.soy +++ b/java/google/registry/ui/soy/registrar/Contact.soy @@ -89,13 +89,13 @@
{if isNonnull($item['contact:postalInfo'])} - {for $pi in $item['contact:postalInfo']} + {foreach $pi in $item['contact:postalInfo']} {call .postalInfo data="all"} {param localized: index($pi) == 1 /} {param item: $pi/} {param namePrefix: 'contact:postalInfo[' + index($pi) + '].contact:' /} {/call} - {/for} + {/foreach} {else} {call .postalInfo data="all"} {param namePrefix: 'contact:postalInfo[0].contact:' /} diff --git a/java/google/registry/ui/soy/registrar/ContactEpp.soy b/java/google/registry/ui/soy/registrar/ContactEpp.soy index 11a2fdd2f..19efe65b6 100644 --- a/java/google/registry/ui/soy/registrar/ContactEpp.soy +++ b/java/google/registry/ui/soy/registrar/ContactEpp.soy @@ -28,7 +28,7 @@ {$item['contact:id']} - {for $pi in $item['contact:postalInfo']} + {foreach $pi in $item['contact:postalInfo']} {$pi['contact:name']} {$pi['contact:org']} @@ -41,7 +41,7 @@ {$addr['contact:cc']} - {/for} + {/foreach} {$item['contact:voice']} {$item['contact:fax']} {$item['contact:email']} @@ -70,7 +70,7 @@ {$item['contact:id']} - {for $pi in $item['contact:postalInfo']} + {foreach $pi in $item['contact:postalInfo']} {$pi['contact:name']} {$pi['contact:org']} @@ -83,7 +83,7 @@ {$addr['contact:cc']} - {/for} + {/foreach} {$item['contact:voice']} {$item['contact:fax']} {$item['contact:email']} diff --git a/java/google/registry/ui/soy/registrar/ContactSettings.soy b/java/google/registry/ui/soy/registrar/ContactSettings.soy index f680094fd..6de3ad200 100644 --- a/java/google/registry/ui/soy/registrar/ContactSettings.soy +++ b/java/google/registry/ui/soy/registrar/ContactSettings.soy @@ -30,7 +30,7 @@

Contact settings

- {for $type in $possibleTypesLookup} + {foreach $type in $possibleTypesLookup} {if isNonnull($contactsByType[$type[0]])} {/if} - {/for} + {/foreach}
@@ -40,7 +40,7 @@ - {for $c in $contactsByType[$type[0]]} + {foreach $c in $contactsByType[$type[0]]} {call .contactInfoCompact} {param namePrefix: 'contacts[' + index($c) + '].' /} {param name: $c['name'] /} @@ -53,10 +53,10 @@ {param faxNumber: $c['faxNumber'] /} {/call} {if (index($c) + 1) % 3 == 0}
{/if} - {/for} + {/foreach}
{/template} @@ -185,11 +185,11 @@
- {for $type in $possibleTypesLookup} + {foreach $type in $possibleTypesLookup} {if $actualTypesLookup[$type[0]]}
{$type[1]} contact
{/if} - {/for} + {/foreach}

@@ -301,7 +301,7 @@ {@param namePrefix: string} {@param actualTypesLookup: map} {@param possibleTypesLookup: list>} - {for $type in $possibleTypesLookup} + {foreach $type in $possibleTypesLookup} {let $name: $namePrefix + 'type.' + $type[0] /} {let $checked: $actualTypesLookup[$type[0]] /}
@@ -314,7 +314,7 @@ {$type[2]}
- {/for} + {/foreach} {/template} diff --git a/java/google/registry/ui/soy/registrar/Domain.soy b/java/google/registry/ui/soy/registrar/Domain.soy index 636bfcefa..12b9f1f6a 100644 --- a/java/google/registry/ui/soy/registrar/Domain.soy +++ b/java/google/registry/ui/soy/registrar/Domain.soy @@ -113,7 +113,7 @@ {if isNonnull($item['domain:ns'] and isNonnull($item['domain:ns']['domain:hostObj']))} - {for $hostObj in $item['domain:ns']['domain:hostObj']} + {foreach $hostObj in $item['domain:ns']['domain:hostObj']} {let $hostIdx: index($hostObj) /} {call registry.soy.forms.inputFieldRowWithValue data="all"} {param label: 'Host ' + $hostIdx /} @@ -121,7 +121,7 @@ {param value: $hostObj /} {param clazz kind="text"}{css('domain-hostObj')}{/param} {/call} - {/for} + {/foreach} {/if} @@ -165,7 +165,7 @@ {template .showContact_ visibility="private"} {@param contacts: list>} /** List of EPP domain:contacts. */ {@param type: string} /** Type of contact (e.g. admin, tech) */ - {for $contact in $contacts} + {foreach $contact in $contacts} {if $type == $contact['@type']} {call registry.soy.forms.inputFieldRowWithValue data="all"} {param label: $contact['@type'] + ' contact' /} @@ -177,7 +177,7 @@ type="hidden" value="{$contact['@type']}"> {/if} - {/for} + {/foreach} {/template} diff --git a/java/google/registry/ui/soy/registrar/DomainEpp.soy b/java/google/registry/ui/soy/registrar/DomainEpp.soy index 66084693f..b8ce93131 100644 --- a/java/google/registry/ui/soy/registrar/DomainEpp.soy +++ b/java/google/registry/ui/soy/registrar/DomainEpp.soy @@ -32,18 +32,18 @@ {/if} {if isNonnull($item['domain:ns'])} - {for $hostObj in $item['domain:ns']['domain:hostObj']} + {foreach $hostObj in $item['domain:ns']['domain:hostObj']} {$hostObj.value} - {/for} + {/foreach} {/if} {if isNonnull($item['domain:registrant'])} {$item['domain:registrant']} {/if} {if isNonnull($item['domain:contact'])} - {for $contact in $item['domain:contact']} + {foreach $contact in $item['domain:contact']} {$contact.value} - {/for} + {/foreach} {/if} {$item['domain:authInfo']['domain:pw']} @@ -128,15 +128,15 @@ <{$tagName}> {if isNonnull($hosts)} - {for $host in $hosts} + {foreach $host in $hosts} {$host.value} - {/for} + {/foreach} {/if} {if isNonnull($contacts)} - {for $contact in $contacts} + {foreach $contact in $contacts} {$contact.value} - {/for} + {/foreach} {/if} {/template} diff --git a/java/google/registry/ui/soy/registrar/Host.soy b/java/google/registry/ui/soy/registrar/Host.soy index 97f22231f..bf74e97bc 100644 --- a/java/google/registry/ui/soy/registrar/Host.soy +++ b/java/google/registry/ui/soy/registrar/Host.soy @@ -59,7 +59,7 @@ {if isNonnull($item['host:addr'])} - {for $addr in $item['host:addr']} + {foreach $addr in $item['host:addr']} {if not $readonly} diff --git a/java/google/registry/ui/soy/registrar/HostEpp.soy b/java/google/registry/ui/soy/registrar/HostEpp.soy index 97524c2cd..3a7d5b089 100644 --- a/java/google/registry/ui/soy/registrar/HostEpp.soy +++ b/java/google/registry/ui/soy/registrar/HostEpp.soy @@ -27,10 +27,10 @@ {$item['host:name']} {if isNonnull($item['host:addr'])} - {for $addr in $item['host:addr']} + {foreach $addr in $item['host:addr']} {let $type: strContains($addr['value'], ':') ? 'v6' : 'v4' /} {$addr['value']} - {/for} + {/foreach} {/if}
@@ -101,10 +101,10 @@ {let $tagName: $isAdd ? 'host:add' : 'host:rem' /} {if length($addrs) > 0} <{$tagName}> - {for $addr in $addrs} + {foreach $addr in $addrs} {let $type: strContains($addr, ':') ? 'v6' : 'v4' /} {$addr} - {/for} + {/foreach} {/if} {/template} diff --git a/java/google/registry/ui/soy/registrar/SecuritySettings.soy b/java/google/registry/ui/soy/registrar/SecuritySettings.soy index ee41efadb..4a6640e71 100644 --- a/java/google/registry/ui/soy/registrar/SecuritySettings.soy +++ b/java/google/registry/ui/soy/registrar/SecuritySettings.soy @@ -47,12 +47,12 @@
- {for $ip in $ipAddressWhitelist} + {foreach $ip in $ipAddressWhitelist} {call .ip} {param name: 'ipAddressWhitelist[' + index($ip) + ']' /} {param ip: $ip /} {/call} - {/for} + {/foreach}
diff --git a/java/google/registry/ui/soy/registrar/WhoisSettings.soy b/java/google/registry/ui/soy/registrar/WhoisSettings.soy index 620a264ec..60d862b4b 100644 --- a/java/google/registry/ui/soy/registrar/WhoisSettings.soy +++ b/java/google/registry/ui/soy/registrar/WhoisSettings.soy @@ -149,13 +149,13 @@ {@param? state: string} {@param? zip: string} {@param countryCode: string} - {for $line in $street} + {foreach $line in $street}
{$street[index($line)]}
- {/for} + {/foreach}