zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-21 11:49:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

Resolve remaining TODO(shicong) (#932)

Browse source
This commit is contained in:
Shicong Huang 2021-01-20 19:27:48 -05:00 • committed by GitHub
parent fbad52223c
commit fcda5d73de
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/google/registry/model/eppcommon/Address.java
View file

@ -175,7 +175,7 @@ public class Address extends ImmutableObject implements Jsonifiable {
* entity from Datastore. * entity from Datastore.
* *
* <p>This callback method is used by Objectify to set streetLine[1,2,3] fields as they are not * <p>This callback method is used by Objectify to set streetLine[1,2,3] fields as they are not
* persisted in the Datastore. TODO(shicong): Delete this method after database migration. * persisted in the Datastore.
*/ */
void onLoad(@AlsoLoad("street") List<String> street) { void onLoad(@AlsoLoad("street") List<String> street) {
mapStreetListToIndividualFields(street); mapStreetListToIndividualFields(street);

4
core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java
View file

@ -116,8 +116,6 @@ public class JpaTransactionManagerImpl implements JpaTransactionManager {
@Override @Override
public <T> T transact(Supplier<T> work) { public <T> T transact(Supplier<T> work) {
// TODO(shicong): Investigate removing transactNew functionality after migration as it may
// be same as this one.
return retrier.callWithRetry( return retrier.callWithRetry(
() -> { () -> {
if (inTransaction()) { if (inTransaction()) {
@ -197,6 +195,8 @@ public class JpaTransactionManagerImpl implements JpaTransactionManager {
}); });
} }
// TODO(b/177674699): Remove all transactNew methods as they are same as transact after the
// database migration.
@Override @Override
public <T> T transactNew(Supplier<T> work) { public <T> T transactNew(Supplier<T> work) {
return transact(work); return transact(work);