zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Update transfer data fixing command to fix one more domain

Browse source 
I happened to notice that one domain affected by b/33289763 had existing transfer data, so in that case the data got overwritten to look like a server cancellation (a year after the transfer request, so obviously wrong) rather than creating invalid transfer data, and hence wasn't picked up in the previous fixes.  See b/33289763#comment32 for more details.

This CL renames the RemoveDomainTransferDataCommand used to fix the errors to FixDomainTransferDataCommand and changes its behavior to instead reset the TransferData to a server-approval result.  It also changes it to load domains by ROID because loadByForeignKey() fails for deleted domains.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159273225
This commit is contained in:
nickfelt 2017-06-16 14:09:42 -07:00 • committed by Ben McIlwain
parent d1ef4b9c37
commit fc78fd7d4a
3 changed files with 59 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

4
java/google/registry/tools/RegistryTool.java
View file

@ -15,8 +15,8 @@
package google.registry.tools;
import com.google.common.collect.ImmutableMap;
import google.registry.tools.javascrap.FixDomainTransferDataCommand;
import google.registry.tools.javascrap.PopulateNullRegistrarFieldsCommand;
import google.registry.tools.javascrap.RemoveDomainTransferDataCommand;
import google.registry.tools.javascrap.RemoveIpAddressCommand;
/** Container class to create and run remote commands against a Datastore instance. */
@ -61,6 +61,7 @@ public final class RegistryTool {
.put("domain_check_fee", DomainCheckFeeCommand.class)
.put("encrypt_escrow_deposit", EncryptEscrowDepositCommand.class)
.put("execute_epp", ExecuteEppCommand.class)
.put("fix_domain_transfer_data", FixDomainTransferDataCommand.class)
.put("generate_applications_report", GenerateApplicationsReportCommand.class)
.put("generate_auction_data", GenerateAuctionDataCommand.class)
.put("generate_dns_report", GenerateDnsReportCommand.class)
@ -103,7 +104,6 @@ public final class RegistryTool {
.put("publish_detail_report", PublishDetailReportCommand.class)
.put("registrar_activity_report", RegistrarActivityReportCommand.class)
.put("registrar_contact", RegistrarContactCommand.class)
.put("remove_domain_transfer_data", RemoveDomainTransferDataCommand.class)
.put("remove_ip_address", RemoveIpAddressCommand.class)
.put("resave_entities", ResaveEntitiesCommand.class)
.put("resave_environment_entities", ResaveEnvironmentEntitiesCommand.class)