Provide better error message for abuse contact phone number

Make it clear that all the user need to do to rectify is to provide a phone number

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=153191178
This commit is contained in:
jianglai 2017-04-14 11:58:21 -07:00 committed by Ben McIlwain
parent db2f08633a
commit fb25b625f3
2 changed files with 6 additions and 5 deletions

View file

@ -286,7 +286,8 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
&& !any(newContactsByType.get(type), HAS_PHONE)) {
throw new ContactRequirementException(
String.format(
"At least one %s contact must have a phone number", type.getDisplayName()));
"Please provide a phone number for at least one %s contact",
type.getDisplayName()));
}
}
}

View file

@ -125,8 +125,8 @@ public class ContactSettingsTest extends RegistrarSettingsActionTestCase {
"op", "update",
"args", reqJson));
assertThat(response).containsEntry("status", "ERROR");
assertThat(response).containsEntry("message", "At least one "
+ RegistrarContact.Type.TECH.getDisplayName() + " contact must have a phone number");
assertThat(response).containsEntry("message", "Please provide a phone number for at least one "
+ RegistrarContact.Type.TECH.getDisplayName() + " contact");
}
@Test
@ -149,7 +149,7 @@ public class ContactSettingsTest extends RegistrarSettingsActionTestCase {
"op", "update",
"args", reqJson));
assertThat(response).containsEntry("status", "ERROR");
assertThat(response).containsEntry("message", "At least one "
+ RegistrarContact.Type.ABUSE.getDisplayName() + " contact must have a phone number");
assertThat(response).containsEntry("message", "Please provide a phone number for at least one "
+ RegistrarContact.Type.ABUSE.getDisplayName() + " contact");
}
}