From f9e1bab1d2f5ad7dc60bb02186ea694ed30f7320 Mon Sep 17 00:00:00 2001 From: ctingue Date: Fri, 25 Mar 2016 08:26:36 -0700 Subject: [PATCH] Rename async flow failure backoff config property ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118207124 --- java/com/google/domain/registry/config/RegistryConfig.java | 4 ++-- .../com/google/domain/registry/config/TestRegistryConfig.java | 2 +- .../google/domain/registry/flows/async/AsyncFlowUtils.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/com/google/domain/registry/config/RegistryConfig.java b/java/com/google/domain/registry/config/RegistryConfig.java index a115f5d3a..416352d3e 100644 --- a/java/com/google/domain/registry/config/RegistryConfig.java +++ b/java/com/google/domain/registry/config/RegistryConfig.java @@ -253,10 +253,10 @@ public interface RegistryConfig { public Duration getAsyncDeleteFlowMapreduceDelay(); /** - * Returns the amount of time to back off following an async delete flow task failure. + * Returns the amount of time to back off following an async flow task failure. * * This should be ~orders of magnitude larger than the rate on the queue, in order to prevent * the logs from filling up with unnecessarily failures. */ - public Duration getAsyncDeleteFlowFailureBackoff(); + public Duration getAsyncFlowFailureBackoff(); } diff --git a/java/com/google/domain/registry/config/TestRegistryConfig.java b/java/com/google/domain/registry/config/TestRegistryConfig.java index 909d4d686..eb809b6aa 100644 --- a/java/com/google/domain/registry/config/TestRegistryConfig.java +++ b/java/com/google/domain/registry/config/TestRegistryConfig.java @@ -190,7 +190,7 @@ public class TestRegistryConfig implements RegistryConfig { } @Override - public Duration getAsyncDeleteFlowFailureBackoff() { + public Duration getAsyncFlowFailureBackoff() { return Duration.standardMinutes(10); } } diff --git a/java/com/google/domain/registry/flows/async/AsyncFlowUtils.java b/java/com/google/domain/registry/flows/async/AsyncFlowUtils.java index e906a6cf2..2b89abf57 100644 --- a/java/com/google/domain/registry/flows/async/AsyncFlowUtils.java +++ b/java/com/google/domain/registry/flows/async/AsyncFlowUtils.java @@ -52,7 +52,7 @@ public final class AsyncFlowUtils { logger.infofmt("Enqueueing async mapreduce action with path %s and params %s", path, params); // Aggressively back off if the task fails, to minimize flooding the logs. RetryOptions retryOptions = RetryOptions.Builder.withMinBackoffSeconds( - RegistryEnvironment.get().config().getAsyncDeleteFlowFailureBackoff().getStandardSeconds()); + RegistryEnvironment.get().config().getAsyncFlowFailureBackoff().getStandardSeconds()); TaskOptions options = TaskOptions.Builder .withUrl(path) .retryOptions(retryOptions)