zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-21 18:26:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add SQL queries to RdapDomainSearchAction (#982)

Browse source 
* Add SQL queries to RdapDomainSearchAction

Unfortunately, because ORDER BY uses the locale's sorting functionality,
we end up with some weird sort orders in SQL-land (notably, periods are
ignored / omitted). As a result, a few of the tests have to be separated
out into ofy and SQL versions based on the expected sort order.

In addition, there isn't a way to query @Convert-ed fields in Postgres
via the standard Hibernate / JPA query language, meaning we have to use
a raw Postgres query for that.
This commit is contained in:
gbrodman 2021-03-09 11:11:53 -05:00 • committed by GitHub
parent 9413dc1e4f
commit f760327ffd
6 changed files with 572 additions and 241 deletions
Download patch file Download diff file Expand all files Collapse all files

1
config/presubmits.py
View file

@ -209,6 +209,7 @@ PRESUBMITS = {
"JpaTransactionManagerImpl.java",
# CriteriaQueryBuilder is a false positive
"CriteriaQueryBuilder.java",
"RdapDomainSearchAction.java",
"RdapSearchActionBase.java",
},
):