From f73e1c06b11654b536f25e9fb4f980d495eda024 Mon Sep 17 00:00:00 2001 From: jart Date: Thu, 18 Aug 2016 17:12:23 -0700 Subject: [PATCH] Remove InetAddress.getLocalHost() from tests It seems the Bazel sandbox has become stricter at HEAD (which is AWESOME) which caused this error to materialize from the shadows: 9) testExpiredTransfer_subordinateHost(google.registry.model.host.HostResourceTest) java.net.UnknownHostException: sandbox: sandbox: unknown error at java.net.InetAddress.getLocalHost(InetAddress.java:1505) at google.registry.model.host.HostResourceTest.setUp(HostResourceTest.java:82) ... Caused by: java.net.UnknownHostException: sandbox: unknown error at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928) at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323) at java.net.InetAddress.getLocalHost(InetAddress.java:1500) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=130700624 --- .../flows/host/HostUpdateFlowTest.java | 12 +++--- .../registry/model/host/HostResourceTest.java | 37 +++++++++++-------- 2 files changed, 28 insertions(+), 21 deletions(-) diff --git a/javatests/google/registry/flows/host/HostUpdateFlowTest.java b/javatests/google/registry/flows/host/HostUpdateFlowTest.java index 3b6b5101f..04f19358d 100644 --- a/javatests/google/registry/flows/host/HostUpdateFlowTest.java +++ b/javatests/google/registry/flows/host/HostUpdateFlowTest.java @@ -38,6 +38,7 @@ import static google.registry.util.DateTimeUtils.END_OF_TIME; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; +import com.google.common.net.InetAddresses; import com.googlecode.objectify.Key; import com.googlecode.objectify.Ref; import google.registry.flows.EppRequestSource; @@ -62,7 +63,6 @@ import google.registry.model.host.HostResource; import google.registry.model.index.ForeignKeyIndex; import google.registry.model.reporting.HistoryEntry; import google.registry.testing.TaskQueueHelper.TaskMatcher; -import java.net.InetAddress; import javax.annotation.Nullable; import org.joda.time.DateTime; import org.junit.Before; @@ -756,10 +756,12 @@ public class HostUpdateFlowTest extends ResourceFlowTestCaseof()).build().inetAddresses) .isNull(); - assertThat(new HostResource.Builder() - .setInetAddresses(ImmutableSet.of(InetAddress.getLocalHost())).build().inetAddresses) - .isNotNull(); + assertThat( + new HostResource.Builder() + .setInetAddresses(ImmutableSet.of(InetAddresses.forString("127.0.0.1"))) + .build() + .inetAddresses) + .isNotNull(); } @Test