zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-11 15:04:46 +02:00
Code Issues Projects Releases Packages Wiki Activity

Enable Java 11 features (#737)

Browse source 
* Enable Java 11 features

As of this commit Java 11 must be used to build. The generated bytecode
is still at Java 8 due to App Engine task queue limit.

Also fixed a bug where the included google-java-format jar file is not
used, requiring the user to install it separately.

See: https://cloud.google.com/appengine/docs/standard/java/taskqueue/push
This commit is contained in:
Lai Jiang 2020-08-03 16:08:29 -04:00 • committed by GitHub
parent 94d91d1663
commit f6749ad663
39 changed files with 2662 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

11
core/src/test/java/google/registry/flows/EppXmlSanitizerTest.java
View file

@ -121,15 +121,10 @@ class EppXmlSanitizerTest {
void testSanitize_utf16_encodingPreserved() {
// Test data should specify an endian-specific UTF-16 scheme for easy assertion. If 'UTF-16' is
// used, the XMLEventReader in sanitizer may resolve it to an endian-specific one.
String inputXml = "<?xml version=\"1.0\" encoding=\"UTF-16LE\"?><p>\u03bc</p>\n";
String inputXml =
"<?xml version=\"1.0\" encoding=\"UTF-16LE\" standalone=\"no\"?>" + "<p>\u03bc</p>\n";
String sanitizedXml = sanitizeEppXml(inputXml.getBytes(UTF_16LE));
// As of Java 9, standalone is always written to the XML header and is defaulted to "no" if not
// otherwise specified. We don't care about that for this specific test, and since we want to be
// compatible with both Java 8 and Java 11 (for now), we strip the standalone="no" attribute if
// it is present prior to doing the string comparison.
// TODO(java11): Remove this stripping and do a full assertion once we no longer care about
// maintaining Java 8 build compatibility.
assertThat(sanitizedXml.replace(" standalone=\"no\"", "")).isEqualTo(inputXml);
assertThat(sanitizedXml).isEqualTo(inputXml);
}
}