zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-08 04:03:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove unnecessary method (#920)

Browse source 
* Remove unnecessary method

The 'id' property no longer exists in the entity hierarchy
This commit is contained in:
Weimin Yu 2021-01-06 11:18:37 -05:00 • committed by GitHub
parent e951077610
commit f5744362e0
1 changed files with 0 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

20
core/src/main/java/google/registry/model/domain/GracePeriodBase.java
View file

@ -17,15 +17,11 @@ package google.registry.model.domain;
import com.googlecode.objectify.annotation.Embed; import com.googlecode.objectify.annotation.Embed;
import com.googlecode.objectify.annotation.Ignore; import com.googlecode.objectify.annotation.Ignore;
import google.registry.model.ImmutableObject; import google.registry.model.ImmutableObject;
import google.registry.model.ModelUtils;
import google.registry.model.billing.BillingEvent; import google.registry.model.billing.BillingEvent;
import google.registry.model.domain.rgp.GracePeriodStatus; import google.registry.model.domain.rgp.GracePeriodStatus;
import google.registry.persistence.BillingVKey.BillingEventVKey; import google.registry.persistence.BillingVKey.BillingEventVKey;
import google.registry.persistence.BillingVKey.BillingRecurrenceVKey; import google.registry.persistence.BillingVKey.BillingRecurrenceVKey;
import google.registry.persistence.VKey; import google.registry.persistence.VKey;
import java.lang.reflect.Field;
import java.util.LinkedHashMap;
import java.util.Map;
import javax.persistence.Access; import javax.persistence.Access;
import javax.persistence.AccessType; import javax.persistence.AccessType;
import javax.persistence.Column; import javax.persistence.Column;
@ -125,20 +121,4 @@ public class GracePeriodBase extends ImmutableObject {
public VKey<BillingEvent.Recurring> getRecurringBillingEvent() { public VKey<BillingEvent.Recurring> getRecurringBillingEvent() {
return billingEventRecurring == null ? null : billingEventRecurring.createVKey(); return billingEventRecurring == null ? null : billingEventRecurring.createVKey();
} }
/**
* Override {@link ImmutableObject#getSignificantFields()} to exclude "id", which breaks equality
* testing in the unit tests.
*/
@Override
protected Map<Field, Object> getSignificantFields() {
// Can't use streams or ImmutableMap because we can have null values.
Map<Field, Object> result = new LinkedHashMap();
for (Map.Entry<Field, Object> entry : ModelUtils.getFieldValues(this).entrySet()) {
if (!entry.getKey().getName().equals("id")) {
result.put(entry.getKey(), entry.getValue());
}
}
return result;
}
} }