Move thrown.expect() right before the throwing statement

aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407

javatests/google/registry/model/common/TimedTransitionPropertyTest.java

@@ -159,16 +159,15 @@ public class TimedTransitionPropertyTest {
 
   @Test
   public void testFailure_noValuesAfterSimulatedEmptyLoad() throws Exception {
-    thrown.expect(IllegalStateException.class);
     timedString = forMapify("0", StringTimedTransition.class);
     // Simulate a load from datastore by clearing, but don't insert any transitions.
     timedString.clear();
+    thrown.expect(IllegalStateException.class);
     timedString.checkValidity();
   }
 
   @Test
   public void testFailure_noValueAtStartOfTimeAfterSimulatedLoad() throws Exception {
-    thrown.expect(IllegalStateException.class);
     // Just for testing, don't extract transitions from a TimedTransitionProperty in real code.
     StringTimedTransition transition1 = timedString.get(DATE_1);
     timedString = forMapify("0", StringTimedTransition.class);
@@ -176,6 +175,7 @@ public class TimedTransitionPropertyTest {
     // omit a transition corresponding to START_OF_TIME.
     timedString.clear();
     timedString.put(DATE_1, transition1);
+    thrown.expect(IllegalStateException.class);
     timedString.checkValidity();
   }
 }