Gray out the password field for admins (#506)

* Gray out the password field for admins

We don't check it for admins since it's not necessary, so ignore it

* Remove the field entirely

core/src/main/javascript/google/registry/ui/js/registrar/registry_lock.js

@@ -45,6 +45,7 @@ registry.registrar.RegistryLock = function(console, resource) {
 goog.inherits(registry.registrar.RegistryLock, registry.ResourceComponent);
 
 registry.registrar.RegistryLock.prototype.runAfterRender = function(objArgs) {
+  this.isAdmin = objArgs.isAdmin;
   this.clientId = objArgs.clientId;
   this.xsrfToken = objArgs.xsrfToken;
 
@@ -114,7 +115,8 @@ registry.registrar.RegistryLock.prototype.showModal_ = function(targetElement, d
   var parentElement = targetElement.parentElement;
   // attach the modal to the parent element so focus remains correct if the user closes the modal
   var modalElement = goog.soy.renderAsElement(
-      registry.soy.registrar.registrylock.confirmModal, {domain: domain, isLock: isLock});
+      registry.soy.registrar.registrylock.confirmModal,
+      {domain: domain, isLock: isLock, isAdmin: this.isAdmin});
   parentElement.prepend(modalElement);
   if (domain == null) {
     goog.dom.getRequiredElement('domain-lock-input-value').focus();

core/src/main/resources/google/registry/ui/soy/registrar/RegistryLock.soy

@@ -106,6 +106,7 @@
 /** Modal that confirms that the user wishes to lock/unlock a domain. */
 {template .confirmModal}
   {@param isLock: bool}
+  {@param isAdmin: bool}
   {@param? domain: string|null}
   <div id="lock-confirm-modal" class="{css('lock-confirm-modal')}">
     <div class="modal-content">
@@ -117,9 +118,11 @@
              value="{$domain}" disabled
           {/if}>
       <br>
-      <label for="domain-lock-password">Registry lock password: </label>
+      {if not $isAdmin}
-      <input type="password" id="domain-lock-password">
+        <label for="domain-lock-password">Registry lock password: </label>
-      <br>
+        <input type="password" id="domain-lock-password">
+        <br>
+      {/if}
       <div id="modal-error-message" hidden class="{css('kd-errormessage')}"></div>
       <div class="{css('buttons-div')}">
         <button id="domain-lock-cancel" class="{css('kd-button')}">Cancel</button>

core/src/test/java/google/registry/webdriver/RegistrarConsoleScreenshotTest.java

@@ -499,7 +499,6 @@ public class RegistrarConsoleScreenshotTest extends WebDriverTestCase {
 
   @Test
   public void registryLock_unlockModal() throws Throwable {
-    server.setIsAdmin(true);
     server.runInAppEngineEnvironment(
         () -> {
           createDomainAndSaveLock();
@@ -527,7 +526,6 @@ public class RegistrarConsoleScreenshotTest extends WebDriverTestCase {
     driver.findElement(By.id("button-lock-domain")).click();
     driver.waitForElement(By.className("modal-content"));
     driver.findElement(By.id("domain-lock-input-value")).sendKeys("somedomain.tld");
-    driver.findElement(By.id("domain-lock-password")).sendKeys("password");
     driver.diffPage("page");
   }