zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-28 07:13:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Move EntityManagerFactoryProviderTest to fragile (#251)

Browse source 
* Move EntityManagerFactoryProviderTest to fragile

* Add EMF Provider Test to docker tests

Add EntityManagerFactoryProviderTest to the docker incompatible test patterns
and use the latter list to compose the fragile tests.
This commit is contained in:
Michael Muller 2019-09-03 19:47:58 -04:00 • committed by GitHub
parent 45b960db1d
commit f26c688f33
1 changed files with 15 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

31
core/build.gradle
View file

@ -43,21 +43,6 @@ def outcastTestPatterns = [
"google/registry/tools/server/CreatePremiumListActionTest.*", "google/registry/tools/server/CreatePremiumListActionTest.*",
] ]
// Tests that conflict with members of both the main test suite and the
// outcast suite. They seem to be affected by global states outside of
// Nomulus classes, e.g., threads and objects retained by frameworks.
// TODO(weiminyu): identify cause and fix offending tests.
def fragileTestPatterns = [
// Problem seems to lie with AppEngine TaskQueue for test.
"google/registry/cron/TldFanoutActionTest.*",
// Test Datastore inexplicably aborts transaction.
"google/registry/model/tmch/ClaimsListShardTest.*",
// Creates large object (64MBytes), occasionally throws OOM error.
"google/registry/model/server/KmsSecretRevisionTest.*",
"google/registry/tools/GenerateSqlSchemaCommandTest.*",
"google/registry/webdriver/*",
]
// Tests that fail when running Gradle in a docker container, e. g. when // Tests that fail when running Gradle in a docker container, e. g. when
// building the release artifacts in Google Cloud Build. // building the release artifacts in Google Cloud Build.
def dockerIncompatibleTestPatterns = [ def dockerIncompatibleTestPatterns = [
@ -70,9 +55,23 @@ def dockerIncompatibleTestPatterns = [
// respected. However when running in Docker the user is root by default, so // respected. However when running in Docker the user is root by default, so
// every file is read/write-able. There is no way to exclude specific test // every file is read/write-able. There is no way to exclude specific test
// methods, so we exclude the whole test class. // methods, so we exclude the whole test class.
"google/registry/tools/params/PathParameterTest.*" "google/registry/tools/params/PathParameterTest.*",
"google/registry/persistence/EntityManagerFactoryProviderTest.*",
] ]
// Tests that conflict with members of both the main test suite and the
// outcast suite. They seem to be affected by global states outside of
// Nomulus classes, e.g., threads and objects retained by frameworks.
// TODO(weiminyu): identify cause and fix offending tests.
def fragileTestPatterns = [
// Problem seems to lie with AppEngine TaskQueue for test.
"google/registry/cron/TldFanoutActionTest.*",
// Test Datastore inexplicably aborts transaction.
"google/registry/model/tmch/ClaimsListShardTest.*",
// Creates large object (64MBytes), occasionally throws OOM error.
"google/registry/model/server/KmsSecretRevisionTest.*",
] + dockerIncompatibleTestPatterns
sourceSets { sourceSets {
main { main {
java { java {