diff --git a/build.gradle b/build.gradle index e3f4ee02d..4fa3d0ec5 100644 --- a/build.gradle +++ b/build.gradle @@ -292,7 +292,8 @@ subprojects { afterEvaluate { if (rootProject.enableDependencyLocking.toBoolean() - && project.name != 'integration') { + && project.name != 'integration' + && project.name != 'java8compatibility') { // The ':integration' project runs server/schema integration tests using // dynamically specified jars with no transitive dependency. Therefore // dependency-locking does not make sense. Furthermore, during @@ -300,6 +301,9 @@ subprojects { // immutable. Locking activation would trigger an invalid operation // exception. // + // The ':java8compatibility' project is test-only. Its source does not go + // into production. + // // For all other projects, due to problem with the gradle-license-report // plugin, the dependencyLicenseReport configuration must opt out of // dependency-locking. See dependency_lic.gradle for the reason why. diff --git a/java8compatibility/build.gradle b/java8compatibility/build.gradle new file mode 100644 index 000000000..fbfaa198d --- /dev/null +++ b/java8compatibility/build.gradle @@ -0,0 +1,41 @@ +// Copyright 2022 The Nomulus Authors. All Rights Reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +configurations { + all_prod_jars +} + +dependencies { + def deps = rootProject.dependencyMap + + testCompile deps['com.google.guava:guava'] + testCompile deps['com.google.truth:truth'] + testCompile deps['org.junit.jupiter:junit-jupiter-api'] + testCompile deps['org.junit.jupiter:junit-jupiter-engine'] + testCompile deps['org.junit.jupiter:junit-jupiter-params'] + testRuntime project(path: ':core', configuration: 'deploy_jar') + + // Collection of jars that get deployed to Appengine. Please refer to + // ../appengine_war.gradle for more information. + // This includes nomulus production classes and all dependencies. + all_prod_jars project(path: ':core', configuration: 'deploy_jar') +} + +test { + def jarlist = configurations.all_prod_jars.each { + it.toURI().toURL() + }.join(',') + + systemProperty 'all_prod_jars', jarlist +} diff --git a/java8compatibility/src/test/java/google/registry/java8compatibility/ByteCodeVersionTest.java b/java8compatibility/src/test/java/google/registry/java8compatibility/ByteCodeVersionTest.java new file mode 100644 index 000000000..61f6d1259 --- /dev/null +++ b/java8compatibility/src/test/java/google/registry/java8compatibility/ByteCodeVersionTest.java @@ -0,0 +1,115 @@ +// Copyright 2022 The Nomulus Authors. All Rights Reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package google.registry.java8compatibility; + +import static com.google.common.truth.Truth.assertThat; +import static com.google.common.truth.Truth.assertWithMessage; + +import com.google.common.base.Splitter; +import com.google.common.collect.ImmutableList; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.util.Enumeration; +import java.util.stream.Stream; +import java.util.zip.ZipEntry; +import java.util.zip.ZipFile; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Verifies that a list of user-specified jars are compatible with Java 8. + * + *
User should use the {@link #JAR_LIST_PROPERTY_NAME} system property to pass in the + * fully-qualified filenames of the jars to be verified, separate by comma. + * + *
To verify Java 8 compatibility, it is not sufficient to run tests with the Java 8 JVM. Many
+ * API jars, notably those for GCP services, are not exercised by tests. This class takes the
+ * conservative approach, and fails if any class is not compatible, regardless if it is in a
+ * production code path.
+ */
+class ByteCodeVersionTest {
+
+ public static final String JAR_LIST_PROPERTY_NAME = "all_prod_jars";
+
+ /**
+ * The major version of bytecode at Java 8 target level. Technically this is a short value.
+ * However, a byte is sufficient for the lifetime of this class.
+ */
+ private static final byte JAVA8_MAJOR_VERSION = (byte) 52;
+ // Offset of the major version number's lower byte in the class file.
+ private static final int MAJOR_VERSION_OFFSET = 7;
+ private static final int HEADER_LENGTH = MAJOR_VERSION_OFFSET + 1;
+
+ private static ImmutableList