zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-20 09:46:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix RDAP quirks uncovered during documentation

Browse source 
There's no reason not to allow a one-character search string when there are no wildcards. And the ROID validity pattern did not allow underscores, which was causing problems with our ROIDs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136256605
This commit is contained in:
mountford 2016-10-15 13:33:11 -07:00 • committed by Ben McIlwain
parent 861fd60d2c
commit f1ad34b12f
5 changed files with 24 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
javatests/google/registry/rdap/RdapEntityActionTest.java
View file

@ -202,8 +202,8 @@ public class RdapEntityActionTest {
@Test
public void testUnknownEntity_returns404() throws Exception {
assertThat(generateActualJson("MISSING-ENTITY")).isEqualTo(
generateExpectedJson("MISSING-ENTITY not found", "rdap_error_404.json"));
assertThat(generateActualJson("_MISSING-ENTITY_")).isEqualTo(
generateExpectedJson("_MISSING-ENTITY_ not found", "rdap_error_404.json"));
assertThat(response.getStatus()).isEqualTo(404);
}