zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-27 06:44:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Enforce monotonicity for IncrementableMetrics

Browse source 
This change enforces that IncrementableMetrics should only monotonically
increase in value, and adds a new increment() method to increment by one, which is slightly faster than incrementBy (due to a lack of non-negative checking) in the common case that the counter should only be incremented by one.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=130578421
This commit is contained in:
shikhman 2016-08-17 16:35:08 -07:00 • committed by Ben McIlwain
parent 01e38790fd
commit f10a7d8fb0
4 changed files with 33 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/monitoring/metrics/StackdriverWriter.java
View file

@ -195,7 +195,7 @@ public class StackdriverWriter implements MetricWriter {
monitoringClient.projects().timeSeries().create(projectResource, request).execute();
for (TimeSeries timeSeries : timeSeriesList) {
pushedPoints.incrementBy(1, timeSeries.getMetricKind(), timeSeries.getValueType());
pushedPoints.increment(timeSeries.getMetricKind(), timeSeries.getValueType());
}
logger.info(String.format("Flushed %d metrics to Stackdriver", timeSeriesList.size()));
}