zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Rename DNL and SMDRL "login" to "loginAndPassword"

Browse source 
They are passed around in the format username:password, whereas just saying
"login" implies it's just a username and not necessarily also a secret
password. Putting password in the variable name makes it obvious what this is
and reduces the likelihood of anyone ever logging it or otherwise using it
inappropriately.

Note that this does not require data migrations as the actual key used to store
the data in KMS remains unchanged.

This is a follow-up to []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=231253964
This commit is contained in:
mcilwain 2019-01-28 11:13:15 -08:00 • committed by Ben McIlwain
parent 0130f91830
commit f0c677b18b
17 changed files with 65 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

12
javatests/google/registry/keyring/kms/KmsKeyringTest.java
View file

@ -137,12 +137,12 @@ public class KmsKeyringTest {
}
@Test
public void test_getMarksdbDnlLogin() {
public void test_getMarksdbDnlLoginAndPassword() {
saveCleartextSecret("marksdb-dnl-login-string");
String marksdbDnlLogin = keyring.getMarksdbDnlLogin();
String marksdbDnlLoginAndPassword = keyring.getMarksdbDnlLoginAndPassword();
assertThat(marksdbDnlLogin).isEqualTo("marksdb-dnl-login-stringmoo");
assertThat(marksdbDnlLoginAndPassword).isEqualTo("marksdb-dnl-login-stringmoo");
}
@Test
@ -155,12 +155,12 @@ public class KmsKeyringTest {
}
@Test
public void test_getMarksdbSmdrlLogin() {
public void test_getMarksdbSmdrlLoginAndPassword() {
saveCleartextSecret("marksdb-smdrl-login-string");
String marksdbSmdrlLogin = keyring.getMarksdbSmdrlLogin();
String marksdbSmdrlLoginAndPassword = keyring.getMarksdbSmdrlLoginAndPassword();
assertThat(marksdbSmdrlLogin).isEqualTo("marksdb-smdrl-login-stringmoo");
assertThat(marksdbSmdrlLoginAndPassword).isEqualTo("marksdb-smdrl-login-stringmoo");
}