Don't include deleted domains in the ICANN reporting total_domains field (#1713)

This shouldn't matter for billing or anything like that because the
actual actions performed that month are still correct, but before this
PR we're including all domains ever created in the total_domains number,
including deleted domains

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/google/nomulus/1713)
<!-- Reviewable:end -->
This commit is contained in:
gbrodman 2022-07-27 16:24:43 -04:00 committed by GitHub
parent d8e77e2ab2
commit f006605753
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 3 deletions

View file

@ -36,7 +36,7 @@ JOIN
tld,
current_sponsor_registrar_id,
domain_name
FROM "Domain" AS d;''')
FROM "Domain" AS d WHERE d.deletion_time > now();''')
ON
current_sponsor_registrar_id = registrar_id
GROUP BY tld, registrar_name

View file

@ -62,7 +62,6 @@ class TransactionsReportingQueryBuilderTest {
TransactionsReportingQueryBuilder queryBuilder =
createQueryBuilder("cloud_sql_icann_reporting");
;
ImmutableMap<String, String> actualQueries = queryBuilder.getViewQueryMap(yearMonth);
for (String queryName : expectedQueryNames) {
String actualTableName = String.format("%s_201709", queryName);

View file

@ -36,7 +36,7 @@ JOIN
tld,
current_sponsor_registrar_id,
domain_name
FROM "Domain" AS d;''')
FROM "Domain" AS d WHERE d.deletion_time > now();''')
ON
current_sponsor_registrar_id = registrar_id
GROUP BY tld, registrar_name