zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-08 20:23:24 +02:00
Code Issues Projects Releases Packages Wiki Activity

Allow addition of extra entity classes for VKey conversion (#877)

Browse source 
* Allow addition of extra entity classes for VKey conversion

This allows us to create VKeys from Keys for test objects that may not
be part of the original codebase.

This isn't used anywhere directly yet but it will be useful in the
future when testing the replay of SQL transactions.
This commit is contained in:
gbrodman 2020-11-19 13:38:28 -05:00 • committed by GitHub
parent 1c7c202a80
commit ef6d3890bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
core/src/test/java/google/registry/model/translators/VKeyTranslatorFactoryTest.java
View file

@ -27,16 +27,24 @@ import google.registry.model.ofy.CommitLogCheckpointRoot;
import google.registry.model.reporting.HistoryEntry;
import google.registry.persistence.VKey;
import google.registry.testing.AppEngineExtension;
import google.registry.testing.TestObject;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
public class VKeyTranslatorFactoryTest {
@RegisterExtension
public final AppEngineExtension appEngine = AppEngineExtension.builder().withDatastore().build();
public final AppEngineExtension appEngine =
AppEngineExtension.builder().withDatastore().withOfyTestEntities(TestObject.class).build();
VKeyTranslatorFactoryTest() {}
@BeforeAll
static void beforeAll() {
VKeyTranslatorFactory.addTestEntityClass(TestObject.class);
}
@Test
void testEntityWithFlatKey() {
// Creating an objectify key instead of a datastore key as this should get a correctly formatted
@ -88,4 +96,11 @@ public class VKeyTranslatorFactoryTest {
assertThat(vkey.getOfyKey()).isEqualTo(key);
assertThat(vkey.getSqlKey()).isEqualTo("ROID-1");
}
@Test
void testExtraEntityClass() {
TestObject testObject = TestObject.create("id", "field");
Key<TestObject> key = Key.create(testObject);
assertThat(VKeyTranslatorFactory.createVKey(key).getSqlKey()).isEqualTo("id");
}
}

14
core/src/test/java/google/registry/testing/TestObject.java
View file

@ -23,6 +23,7 @@ import com.googlecode.objectify.annotation.Parent;
import google.registry.model.ImmutableObject;
import google.registry.model.annotations.VirtualEntity;
import google.registry.model.common.EntityGroupRoot;
import google.registry.persistence.VKey;
import google.registry.schema.replay.EntityTest.EntityForTesting;
/** A test model object that can be persisted in any entity group. */
@ -30,11 +31,9 @@ import google.registry.schema.replay.EntityTest.EntityForTesting;
@EntityForTesting
public class TestObject extends ImmutableObject {
@Parent
Key<EntityGroupRoot> parent;
@Parent Key<EntityGroupRoot> parent;
@Id
String id;
@Id String id;
String field;
@ -46,6 +45,10 @@ public class TestObject extends ImmutableObject {
return field;
}
public static VKey<TestObject> createVKey(Key<TestObject> key) {
return VKey.create(TestObject.class, key.getName(), key);
}
public static TestObject create(String id) {
return create(id, null);
}
@ -68,8 +71,7 @@ public class TestObject extends ImmutableObject {
@EntityForTesting
public static class TestVirtualObject extends ImmutableObject {
@Id
String id;
@Id String id;
/**
* Expose a factory method for testing saves of virtual entities; in real life this would never