diff --git a/core/src/main/java/google/registry/model/common/DatabaseMigrationStateSchedule.java b/core/src/main/java/google/registry/model/common/DatabaseMigrationStateSchedule.java index 513808691..3cb240657 100644 --- a/core/src/main/java/google/registry/model/common/DatabaseMigrationStateSchedule.java +++ b/core/src/main/java/google/registry/model/common/DatabaseMigrationStateSchedule.java @@ -222,7 +222,7 @@ public class DatabaseMigrationStateSchedule extends CrossTldSingleton implements @VisibleForTesting static TimedTransitionProperty getUncached() { return jpaTm() - .transactNew( + .transactWithoutBackup( () -> { try { return jpaTm() diff --git a/core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java b/core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java index 566e86af9..f73239fc1 100644 --- a/core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java +++ b/core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java @@ -32,7 +32,6 @@ import google.registry.model.common.DatabaseMigrationStateSchedule.MigrationStat import google.registry.model.ofy.CommitLogBucket; import google.registry.model.ofy.Ofy; import google.registry.persistence.VKey; -import google.registry.persistence.transaction.JpaTransactionManagerImpl; import google.registry.persistence.transaction.TransactionEntity; import google.registry.testing.AppEngineExtension; import google.registry.testing.DatabaseHelper; @@ -69,7 +68,6 @@ public class ReplicateToDatastoreActionTest { @BeforeEach public void setUp() { - JpaTransactionManagerImpl.removeReplaySqlToDsOverrideForTest(); injectExtension.setStaticField(Ofy.class, "clock", fakeClock); // Use a single bucket to expose timestamp inversion problems. injectExtension.setStaticField( diff --git a/core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerExtension.java b/core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerExtension.java index 5c621a5ae..2c58964a8 100644 --- a/core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerExtension.java +++ b/core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerExtension.java @@ -203,12 +203,12 @@ abstract class JpaTransactionManagerExtension implements BeforeEachCallback, Aft JpaTransactionManagerImpl txnManager = new JpaTransactionManagerImpl(emf, clock); cachedTm = TransactionManagerFactory.jpaTm(); TransactionManagerFactory.setJpaTm(Suppliers.ofInstance(txnManager)); - JpaTransactionManagerImpl.setReplaySqlToDatastoreOverrideForTest(false); } @Override public void afterEach(ExtensionContext context) { TransactionManagerFactory.setJpaTm(Suppliers.ofInstance(cachedTm)); + // Even though we didn't set this, reset it to make sure no other tests are affected JpaTransactionManagerImpl.removeReplaySqlToDsOverrideForTest(); cachedTm = null; } diff --git a/core/src/test/java/google/registry/persistence/transaction/TransactionTest.java b/core/src/test/java/google/registry/persistence/transaction/TransactionTest.java index c1215c7a2..d87594cba 100644 --- a/core/src/test/java/google/registry/persistence/transaction/TransactionTest.java +++ b/core/src/test/java/google/registry/persistence/transaction/TransactionTest.java @@ -58,7 +58,6 @@ class TransactionTest { @BeforeEach void beforeEach() { - JpaTransactionManagerImpl.removeReplaySqlToDsOverrideForTest(); inject.setStaticField(Ofy.class, "clock", fakeClock); fooEntity = new TestEntity("foo"); barEntity = new TestEntity("bar"); diff --git a/core/src/test/java/google/registry/testing/ReplayExtension.java b/core/src/test/java/google/registry/testing/ReplayExtension.java index 3aab237d0..3ae42ca4c 100644 --- a/core/src/test/java/google/registry/testing/ReplayExtension.java +++ b/core/src/test/java/google/registry/testing/ReplayExtension.java @@ -105,7 +105,7 @@ public class ReplayExtension implements BeforeEachCallback, AfterEachCallback { replay(); injectExtension.afterEach(context); if (sqlToDsReplicator != null) { - JpaTransactionManagerImpl.setReplaySqlToDatastoreOverrideForTest(false); + JpaTransactionManagerImpl.removeReplaySqlToDsOverrideForTest(); } }