zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove unnecessary explicit generic type declarations

Browse source 
They can be inferred correctly even in Java 7, and display as
compiler warnings in IntelliJ.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=173451087
This commit is contained in:
mcilwain 2017-10-25 14:35:29 -07:00 • committed by jianglai
parent 0fdc189e9c
commit eed2e0c45f
20 changed files with 37 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

18
javatests/google/registry/batch/MapreduceEntityCleanupActionTest.java
View file

@ -73,7 +73,7 @@ public class MapreduceEntityCleanupActionTest
private final FakeClock clock = new FakeClock(DateTime.now(UTC));
private final FakeResponse response = new FakeResponse();
private static final ImmutableList<List<String>> inputStrings = ImmutableList.<List<String>>of(
private static final ImmutableList<List<String>> inputStrings = ImmutableList.of(
ImmutableList.of("a", "b", "c"),
ImmutableList.of("d", "e", "f", "g", "h"),
ImmutableList.of("i", "j", "k"),
@ -119,23 +119,19 @@ public class MapreduceEntityCleanupActionTest
}
private void setAnyJobAndDaysOld(int daysOld) {
setJobIdJobNameAndDaysOld(
Optional.<String>empty(), Optional.<String>empty(), Optional.<Integer>of(daysOld));
setJobIdJobNameAndDaysOld(Optional.empty(), Optional.empty(), Optional.of(daysOld));
}
private void setJobId(String jobId) {
setJobIdJobNameAndDaysOld(
Optional.of(jobId), Optional.<String>empty(), Optional.<Integer>empty());
setJobIdJobNameAndDaysOld(Optional.of(jobId), Optional.empty(), Optional.empty());
}
private void setJobName(String jobName) {
setJobIdJobNameAndDaysOld(
Optional.<String>empty(), Optional.of(jobName), Optional.<Integer>empty());
setJobIdJobNameAndDaysOld(Optional.empty(), Optional.of(jobName), Optional.empty());
}
private void setJobNameAndDaysOld(String jobName, int daysOld) {
setJobIdJobNameAndDaysOld(
Optional.<String>empty(), Optional.of(jobName), Optional.<Integer>of(daysOld));
setJobIdJobNameAndDaysOld(Optional.empty(), Optional.of(jobName), Optional.of(daysOld));
}
private void setJobIdJobNameAndDaysOld(
@ -144,9 +140,9 @@ public class MapreduceEntityCleanupActionTest
action = new MapreduceEntityCleanupAction(
jobId,
jobName,
Optional.<Integer>empty(), // numJobsToDelete
Optional.empty(), // numJobsToDelete
daysOld,
Optional.<Boolean>empty(), // force
Optional.empty(), // force
mapreduceEntityCleanupUtil,
clock,
DatastoreServiceFactory.getDatastoreService(),