zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Resolve some Guava 20 TODOs (mostly unnecessary asList() calls)

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=146799536
This commit is contained in:
mcilwain 2017-02-07 10:06:28 -08:00 • committed by Ben McIlwain
parent f212a53232
commit ec55aa5361
12 changed files with 18 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

4
java/google/registry/util/FormattingLogger.java
View file

@ -14,8 +14,6 @@
package google.registry.util;
import static java.util.Arrays.asList;
import com.google.common.base.Predicate;
import com.google.common.collect.FluentIterable;
import java.util.logging.Handler;
@ -38,7 +36,7 @@ public class FormattingLogger {
private void log(Level level, Throwable cause, String msg) {
StackTraceElement callerFrame = FluentIterable
.from(asList(new Exception().getStackTrace()))
.from(new Exception().getStackTrace())
.firstMatch(new Predicate<StackTraceElement>() {
@Override
public boolean apply(StackTraceElement frame) {

11
java/google/registry/util/Retrier.java
View file

@ -15,6 +15,7 @@
package google.registry.util;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Throwables.throwIfUnchecked;
import static com.google.common.collect.Iterables.any;
import static com.google.common.math.IntMath.pow;
import static google.registry.util.PredicateUtils.supertypeOf;
@ -103,14 +104,4 @@ public class Retrier implements Serializable {
return any(retryables, supertypeOf(e.getClass()));
}});
}
// TODO(user): Replace with Throwables.throwIfUnchecked
private static void throwIfUnchecked(Throwable throwable) {
if (throwable instanceof RuntimeException) {
throw (RuntimeException) throwable;
}
if (throwable instanceof Error) {
throw (Error) throwable;
}
}
}