zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make lock index parameters non-optional

Browse source 
The optional code has been around for a while, we can get rid of it now.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=192344612
This commit is contained in:
larryruili 2018-04-10 14:15:52 -07:00 • committed by jianglai
parent 3dfd141e0f
commit ea995cf801
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
java/google/registry/dns/DnsModule.java
View file

@ -24,7 +24,7 @@ import static google.registry.dns.PublishDnsUpdatesAction.PARAM_NUM_PUBLISH_LOCK
import static google.registry.dns.PublishDnsUpdatesAction.PARAM_PUBLISH_TASK_ENQUEUED; import static google.registry.dns.PublishDnsUpdatesAction.PARAM_PUBLISH_TASK_ENQUEUED;
import static google.registry.dns.PublishDnsUpdatesAction.PARAM_REFRESH_REQUEST_CREATED; import static google.registry.dns.PublishDnsUpdatesAction.PARAM_REFRESH_REQUEST_CREATED;
import static google.registry.request.RequestParameters.extractEnumParameter; import static google.registry.request.RequestParameters.extractEnumParameter;
import static google.registry.request.RequestParameters.extractOptionalIntParameter; import static google.registry.request.RequestParameters.extractIntParameter;
import static google.registry.request.RequestParameters.extractRequiredParameter; import static google.registry.request.RequestParameters.extractRequiredParameter;
import static google.registry.request.RequestParameters.extractSetOfParameters; import static google.registry.request.RequestParameters.extractSetOfParameters;
@ -96,15 +96,13 @@ public abstract class DnsModule {
@Provides @Provides
@Parameter(PARAM_LOCK_INDEX) @Parameter(PARAM_LOCK_INDEX)
static int provideLockIndex(HttpServletRequest req) { static int provideLockIndex(HttpServletRequest req) {
// TODO(b/72150053): Make non-optional once this cl has reached production for an hour return extractIntParameter(req, PARAM_LOCK_INDEX);
return extractOptionalIntParameter(req, PARAM_LOCK_INDEX).orElse(1);
} }
@Provides @Provides
@Parameter(PARAM_NUM_PUBLISH_LOCKS) @Parameter(PARAM_NUM_PUBLISH_LOCKS)
static int provideMaxNumLocks(HttpServletRequest req) { static int provideMaxNumLocks(HttpServletRequest req) {
// TODO(b/72150053): Make non-optional once this cl has reached production for an hour return extractIntParameter(req, PARAM_NUM_PUBLISH_LOCKS);
return extractOptionalIntParameter(req, PARAM_NUM_PUBLISH_LOCKS).orElse(1);
} }
@Provides @Provides