zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 08:27:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add missing @Test, @Before, or @After annotations to JUnit4 test, setUp, or tearDown methods; reduce the visibility of test helper methods to prevent them from being confused for tests; and/or add @Ignore to purposely disabled tests.

Browse source 
This paves the way for [] which expands the set of classes Blaze will check for possible test methods that are not properly annotated.

For more details and FAQs please see: []

Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=161795590
This commit is contained in:
Ben McIlwain 2017-07-13 05:43:41 -07:00
parent fc327ec9fb
commit ea4572b4b5
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
javatests/google/registry/tools/SetupOteCommandTest.java
View file

@ -169,6 +169,7 @@ public class SetupOteCommandTest extends CommandTestCase<SetupOteCommand> {
verifyRegistrarCreation("blobio-4", "blobio-ga", passwords.get(3), ipAddresses); verifyRegistrarCreation("blobio-4", "blobio-ga", passwords.get(3), ipAddresses);
} }
@Test
public void testSuccess_alternatePremiumList() throws Exception { public void testSuccess_alternatePremiumList() throws Exception {
runCommandForced( runCommandForced(
"--ip_whitelist=1.1.1.1", "--ip_whitelist=1.1.1.1",

9
javatests/google/registry/tools/UploadClaimsListCommandTest.java
View file

@ -44,6 +44,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
.isEqualTo("2013041500/A/C/7/rHdC4wnrWRvPY6nneCVtQhFj0000000003"); .isEqualTo("2013041500/A/C/7/rHdC4wnrWRvPY6nneCVtQhFj0000000003");
} }
@Test
public void testFailure_wrongNumberOfFieldsOnFirstLine() throws Exception { public void testFailure_wrongNumberOfFieldsOnFirstLine() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,2012-08-16T00:00:00.0Z,random-extra-field", "1,2012-08-16T00:00:00.0Z,random-extra-field",
@ -55,6 +56,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_wrongVersion() throws Exception { public void testFailure_wrongVersion() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"2,2012-08-16T00:00:00.0Z", "2,2012-08-16T00:00:00.0Z",
@ -66,6 +68,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_badCreationTime() throws Exception { public void testFailure_badCreationTime() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -77,6 +80,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_badFirstHeader() throws Exception { public void testFailure_badFirstHeader() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -88,6 +92,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_badSecondHeader() throws Exception { public void testFailure_badSecondHeader() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -99,6 +104,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_badThirdHeader() throws Exception { public void testFailure_badThirdHeader() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -110,6 +116,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_wrongNumberOfHeaders() throws Exception { public void testFailure_wrongNumberOfHeaders() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -121,6 +128,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_wrongNumberOfFields() throws Exception { public void testFailure_wrongNumberOfFields() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",
@ -132,6 +140,7 @@ public class UploadClaimsListCommandTest extends CommandTestCase<UploadClaimsLis
runCommand("--force", filename); runCommand("--force", filename);
} }
@Test
public void testFailure_badInsertionTime() throws Exception { public void testFailure_badInsertionTime() throws Exception {
String filename = writeToTmpFile( String filename = writeToTmpFile(
"1,foo", "1,foo",