zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make Router reject classes with no @Action-returning methods

Browse source 
This provides a safeguard against using TypeInstantiator to resolve the component class, where if resolution is done incorrectly, you end up with java.lang.Object.  Formerly, that would have "succeeded" in generating a Router for Object, which of course has no methods that return @Action classes.  Such a router is pretty useless, so it's better to make Router stricter and have it fail if you give it such a class by accident.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=148353224
This commit is contained in:
nickfelt 2017-02-23 09:36:50 -08:00 • committed by Ben McIlwain
parent d8ce444251
commit ea3a8dfa9d
3 changed files with 19 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
java/google/registry/request/Router.java
View file

@ -14,6 +14,7 @@
package google.registry.request;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Throwables.throwIfUnchecked;
import com.google.common.base.Function;
@ -47,6 +48,8 @@ final class Router {
private Router(Class<?> componentClass) {
this.routes = extractRoutesFromComponent(componentClass);
checkArgument(
!this.routes.isEmpty(), "No routes found for class: %s", componentClass.getCanonicalName());
}
/** Returns the appropriate action route for a request. */