zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use string keys for the multimap of pricing engines for TLDs

Browse source 
This is better than the previous way of using the canonical name of the class,
because the previous way did not allow for refactoring, and also required the
PremiumPricingEngine to live in the model package lest there be circular
dependencies, which does not seem ideal.

Note that, for reasons of backwards compatibility with existing persisted data,
the name of the static premium pricing engine has been set to its canonical
class name, but the class can now be refactored going forward so long as this
string remains unchanged, and any new pricing engine implementations can use
whatever string key they want (it doesn't have to be a canonical class name).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=129215185
This commit is contained in:
mcilwain 2016-08-03 08:08:27 -07:00 • committed by Ben McIlwain
parent 7cc7dc4af2
commit ea24f6ca31
9 changed files with 26 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

15
java/google/registry/pricing/PricingModule.java
View file

@ -14,10 +14,10 @@
package google.registry.pricing;
import dagger.MapKey;
import dagger.Module;
import dagger.Provides;
import dagger.multibindings.IntoMap;
import dagger.multibindings.StringKey;
import google.registry.model.pricing.PremiumPricingEngine;
import google.registry.model.pricing.StaticPremiumListPricingEngine;
@ -25,21 +25,14 @@ import google.registry.model.pricing.StaticPremiumListPricingEngine;
* Dagger module for injecting pricing engines.
*
* <p>To add a new pricing engine, create a new class that implements {@link PremiumPricingEngine},
* and add a module that provides an instance of {@link PremiumPricingEngine} with a
* {@link PremiumPricingEngineClassKey} annotation with the class of the implementation and also
* <code>@Provides @IntoMap</code> annotations.
* and add a module that provides an instance of {@link PremiumPricingEngine} with a unique
* {@link StringKey} annotation, and also <code>@Provides @IntoMap</code> annotations.
*/
@Module
public class PricingModule {
/** The annotation used for PricingEngine implementation keys. */
@MapKey
@interface PremiumPricingEngineClassKey {
Class<? extends PremiumPricingEngine> value();
}
@Provides @IntoMap
@PremiumPricingEngineClassKey(StaticPremiumListPricingEngine.class)
@StringKey(StaticPremiumListPricingEngine.NAME)
static PremiumPricingEngine provideStaticPremiumList(StaticPremiumListPricingEngine engine) {
return engine;
}