zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Rename all encoding methods to start with the word encode for consistency

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=143973446
This commit is contained in:
shikhman 2017-01-09 09:53:30 -08:00 • committed by Ben McIlwain
parent 2a3a17d653
commit e981bad0b3
2 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

12
java/google/registry/monitoring/metrics/StackdriverWriter.java
View file

@ -127,7 +127,7 @@ public class StackdriverWriter implements MetricWriter {
private final RateLimiter rateLimiter;
/**
* Constructs a StackdriverWriter.
* Constructs a {@link StackdriverWriter}.
*
* <p>The monitoringClient must have read and write permissions to the Cloud Monitoring API v3 on
* the provided project.
@ -135,7 +135,7 @@ public class StackdriverWriter implements MetricWriter {
@Inject
public StackdriverWriter(
Monitoring monitoringClient,
String project,
@Named("stackdriverGcpProject") String project,
MonitoredResource monitoredResource,
@Named("stackdriverMaxQps") int maxQps,
@Named("stackdriverMaxPointsPerRequest") int maxPointsPerRequest) {
@ -148,7 +148,7 @@ public class StackdriverWriter implements MetricWriter {
}
@VisibleForTesting
static ImmutableList<LabelDescriptor> createLabelDescriptors(
static ImmutableList<LabelDescriptor> encodeLabelDescriptors(
ImmutableSet<google.registry.monitoring.metrics.LabelDescriptor> labelDescriptors) {
List<LabelDescriptor> stackDriverLabelDescriptors = new ArrayList<>(labelDescriptors.size());
@ -164,14 +164,14 @@ public class StackdriverWriter implements MetricWriter {
}
@VisibleForTesting
static <V> MetricDescriptor createMetricDescriptor(
static <V> MetricDescriptor encodeMetricDescriptor(
google.registry.monitoring.metrics.Metric<V> metric) {
return new MetricDescriptor()
.setType(METRIC_DOMAIN + metric.getMetricSchema().name())
.setDescription(metric.getMetricSchema().description())
.setDisplayName(metric.getMetricSchema().valueDisplayName())
.setValueType(ENCODED_METRIC_TYPES.get(metric.getValueClass()))
.setLabels(createLabelDescriptors(metric.getMetricSchema().labels()))
.setLabels(encodeLabelDescriptors(metric.getMetricSchema().labels()))
.setMetricKind(ENCODED_METRIC_KINDS.get(metric.getMetricSchema().kind().name()));
}
@ -230,7 +230,7 @@ public class StackdriverWriter implements MetricWriter {
return registeredDescriptors.get(metric);
}
MetricDescriptor descriptor = createMetricDescriptor(metric);
MetricDescriptor descriptor = encodeMetricDescriptor(metric);
rateLimiter.acquire();
// We try to create a descriptor, but it may have been created already, so we re-fetch it on