zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-07 04:55:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

Delete private="true" from .soy files

Browse source 
private="true" has never done very much unfortunately. There is an alternate
way to mark templates as private by setting 'visibility="private"' which does
get enforced both by the soy compiler and by custom per-language strategies in
the various backends.

Unfortunately, it isn't possible to safely migrate from one to the other since
users may be calling these templates from server side soy which enforces
visibility via a runtime exception.  So they are just being deleted.

LSC: https://docs.google.com/document/d/1aOM_tBmanDQolF8mAuB0y29yB76cmYS5qOVYBAzFzyw/edit#

Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159565458
This commit is contained in:
lukes 2017-06-20 08:46:56 -07:00 • committed by Ben McIlwain
parent 2b7f78db98
commit e94ba8d2af
4 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/ui/soy/registrar/Console.soy
View file

@ -75,7 +75,7 @@
/** Sidebar nav. Ids on each elt for testing only. */ /** Sidebar nav. Ids on each elt for testing only. */
{template .navbar_ private="true"} {template .navbar_ visibility="private"}
{@param showPaymentLink: bool} {@param showPaymentLink: bool}
<div id="reg-nav" class="{css kd-content-sidebar}"> <div id="reg-nav" class="{css kd-content-sidebar}">
<ul id="reg-navlist"> <ul id="reg-navlist">

8
java/google/registry/ui/soy/registrar/ContactSettings.soy
View file

@ -176,7 +176,7 @@
/** @private */ /** @private */
{template .contactTypeSettingsView_ private="true"} {template .contactTypeSettingsView_ visibility="private"}
{@param item: map<string, ?>} {@param item: map<string, ?>}
{@param possibleTypesLookup: list<list<string>>} {@param possibleTypesLookup: list<list<string>>}
{@param actualTypesLookup: map<string, bool>} {@param actualTypesLookup: map<string, bool>}
@ -217,7 +217,7 @@
/** @private */ /** @private */
{template .contactTypeSettingsEdit_ private="true"} {template .contactTypeSettingsEdit_ visibility="private"}
{@param item: map<string, ?>} {@param item: map<string, ?>}
{@param namePrefix: string} {@param namePrefix: string}
{@param possibleTypesLookup: list<list<string>>} {@param possibleTypesLookup: list<list<string>>}
@ -263,7 +263,7 @@
/** @private */ /** @private */
{template .whoisVisibleRadios_ private="true"} {template .whoisVisibleRadios_ visibility="private"}
{@param description: string} {@param description: string}
{@param? note: string} {@param? note: string}
{@param fieldName: string} {@param fieldName: string}
@ -297,7 +297,7 @@
/** @private */ /** @private */
{template .contactCheckboxes_ private="true"} {template .contactCheckboxes_ visibility="private"}
{@param namePrefix: string} {@param namePrefix: string}
{@param actualTypesLookup: map<string, bool>} {@param actualTypesLookup: map<string, bool>}
{@param possibleTypesLookup: list<list<string>>} {@param possibleTypesLookup: list<list<string>>}

2
java/google/registry/ui/soy/registrar/Domain.soy
View file

@ -162,7 +162,7 @@
/** Renders an input form row for a specific type of contact. */ /** Renders an input form row for a specific type of contact. */
{template .showContact_ private="true"} {template .showContact_ visibility="private"}
{@param contacts: list<map<string, ?>>} /** List of EPP domain:contacts. */ {@param contacts: list<map<string, ?>>} /** List of EPP domain:contacts. */
{@param type: string} /** Type of contact (e.g. admin, tech) */ {@param type: string} /** Type of contact (e.g. admin, tech) */
{foreach $contact in $contacts} {foreach $contact in $contacts}

6
java/google/registry/ui/soy/registrar/WhoisSettings.soy
View file

@ -78,7 +78,7 @@
/** /**
* Contact info. * Contact info.
*/ */
{template .contactInfo_ private="true"} {template .contactInfo_ visibility="private"}
{@param emailAddress: string} {@param emailAddress: string}
{@param readonly: bool} {@param readonly: bool}
{@param? localizedAddress: ?} {@param? localizedAddress: ?}
@ -142,7 +142,7 @@
/** /**
* Read-only view of address. * Read-only view of address.
*/ */
{template .viewAddress_ private="true"} {template .viewAddress_ visibility="private"}
{@param id: string} {@param id: string}
{@param street: list<string>} {@param street: list<string>}
{@param city: string} {@param city: string}
@ -177,7 +177,7 @@
/** /**
* Editor of address. * Editor of address.
*/ */
{template .editAddress_ private="true"} {template .editAddress_ visibility="private"}
{@param id: string} {@param id: string}
{@param? street: list<string>} {@param? street: list<string>}
{@param? city: string} {@param? city: string}