From e94ab94d13b1311a4ed10ec35701f82855badd30 Mon Sep 17 00:00:00 2001 From: guyben Date: Tue, 22 Aug 2017 13:05:07 -0700 Subject: [PATCH] Shorten the lock timeout for rdeStaging Sometimes rdeStaging reduce shards die after the lock is acquired. When that happens - the (automatic) rerun of the shard fails because the lock is in place causing that specific TLD to not stage and await the next call to rdeStaging. rdeStaging runs every 4 hours, but the current lock lives for 5 hours. This means that on the next rerun of rdeStaging, the lock still hasn't timed out so it fails again, and we have to wait for the subsequent run - a total delay of 8 hours. Shortening the lock timeout to be less than the 4 hours rdeStaging rerun time solves this issue. NOTE: This is just a "quick patch" solution. To really fix the rdeStaging failure we need to fix the lock itself. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=166102387 --- java/google/registry/config/RegistryConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/google/registry/config/RegistryConfig.java b/java/google/registry/config/RegistryConfig.java index 54bc85b1d..7182edda7 100644 --- a/java/google/registry/config/RegistryConfig.java +++ b/java/google/registry/config/RegistryConfig.java @@ -579,7 +579,7 @@ public final class RegistryConfig { @Provides @Config("rdeStagingLockTimeout") public static Duration provideRdeStagingLockTimeout() { - return Duration.standardHours(5); + return Duration.standardHours(2); } /**