mirror of
https://github.com/google/nomulus.git
synced 2025-07-19 17:26:09 +02:00
Make RegistryJpaIO use CriteriaQuery intead of QueryComposer (#1209)
QueryComposer could be used when the transaction manager is not determined (i. e. it supports both ofy and sql), but this also imposes limits on what you can do with it. For example it does not support IN operator in the where clause. Since QueryComposer itself creates a CriteriaQuery for JPA TM it make sense to have RegistryJpaIO take a CriteriaQuery directly as it only uses JPA. Also add some more helper methods to use native queries and typed queires, and fix some generic type warnings. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/google/nomulus/1209) <!-- Reviewable:end -->
This commit is contained in:
parent
8771222d9f
commit
e4e7c5ead2
7 changed files with 170 additions and 73 deletions
|
@ -202,6 +202,8 @@ PRESUBMITS = {
|
|||
"java",
|
||||
# ActivityReportingQueryBuilder deals with Dremel queries
|
||||
{"src/test", "ActivityReportingQueryBuilder.java",
|
||||
# This class contains helper method to make queries in Beam.
|
||||
"RegistryJpaIO.java",
|
||||
# TODO(b/179158393): Remove everything below, which should be done
|
||||
# using Criteria
|
||||
"ForeignKeyIndex.java",
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue