zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Install DummyKeyringModule in FOSS build

Browse source 
Per discussions here:

https://groups.google.com/forum/#!topic/nomulus-discuss/ylDW2PblL60

Any use of keyring in the FOSS build would result in crashes because KMS is not configured. We should use the dummy keyring instead so that a vanilla FOSS deployment to GAE can run. Of course users would still need to configure their keyrings (and revert back to KMS keyring module) when they actually use any of the keys.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=175868399
This commit is contained in:
jianglai 2017-11-15 13:05:47 -08:00
parent 8521c69caa
commit e4c5024400
4 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
java/google/registry/module/backend/BackendComponent.java
View file

@ -25,7 +25,6 @@ import google.registry.groups.DirectoryModule;
import google.registry.groups.GroupsModule;
import google.registry.groups.GroupssettingsModule;
import google.registry.keyring.api.KeyModule;
import google.registry.keyring.kms.KeyringModule;
import google.registry.keyring.kms.KmsModule;
import google.registry.module.backend.BackendRequestComponent.BackendRequestComponentModule;
import google.registry.monitoring.metrics.MetricReporter;
@ -57,6 +56,7 @@ import javax.inject.Singleton;
ConfigModule.class,
DatastoreServiceModule.class,
DirectoryModule.class,
google.registry.keyring.api.DummyKeyringModule.class,
DriveModule.class,
GcsServiceModule.class,
GoogleCredentialModule.class,
@ -65,7 +65,6 @@ import javax.inject.Singleton;
JSchModule.class,
Jackson2Module.class,
KeyModule.class,
KeyringModule.class,
KmsModule.class,
ModulesServiceModule.class,
NetHttpTransportModule.class,