zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-29 08:50:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

Enable more DNS update metrics on production

Browse source 
They are useful for viewing and diagnosing problems, and are not that
expensive.

We aren't enabling all the metrics though - the whole "per batch / per domain"
performance indicators are still disabled

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=250876554
This commit is contained in:
guyben 2019-05-31 06:41:20 -07:00 • committed by Ben McIlwain
parent dd66664e42
commit e489539df4
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
java/google/registry/dns/DnsMetrics.java
View file

@ -220,10 +220,15 @@ public class DnsMetrics {
Duration processingDuration, Duration processingDuration,
int numberOfDomains, int numberOfDomains,
int numberOfHosts) { int numberOfHosts) {
// We don't want to record all these metrics in production, as they are quite expensive commitCount.increment(tld, status.name(), dnsWriter);
domainsCommittedCount.incrementBy(numberOfDomains, tld, status.name(), dnsWriter);
hostsCommittedCount.incrementBy(numberOfHosts, tld, status.name(), dnsWriter);
// We don't want to record the following metrics in production, as they are quite expensive
if (registryEnvironment == RegistryEnvironment.PRODUCTION) { if (registryEnvironment == RegistryEnvironment.PRODUCTION) {
return; return;
} }
int batchSize = numberOfDomains + numberOfHosts; int batchSize = numberOfDomains + numberOfHosts;
processingTimePerCommitDist.record( processingTimePerCommitDist.record(
@ -244,10 +249,6 @@ public class DnsMetrics {
totalBatchSizePerCommitDist.record(batchSize, tld, status.name(), dnsWriter); totalBatchSizePerCommitDist.record(batchSize, tld, status.name(), dnsWriter);
totalBatchSizePerItemDist.record(batchSize, batchSize, tld, status.name(), dnsWriter); totalBatchSizePerItemDist.record(batchSize, batchSize, tld, status.name(), dnsWriter);
commitCount.increment(tld, status.name(), dnsWriter);
domainsCommittedCount.incrementBy(numberOfDomains, tld, status.name(), dnsWriter);
hostsCommittedCount.incrementBy(numberOfHosts, tld, status.name(), dnsWriter);
} }
void recordActionResult( void recordActionResult(