Clean up some code quality issues

This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177182945
This commit is contained in:
mcilwain 2017-11-28 10:35:57 -08:00 committed by jianglai
parent 0935ba6450
commit e2db3f914e
109 changed files with 286 additions and 379 deletions

View file

@ -60,16 +60,16 @@ public class DeterministicStringGenerator extends StringGenerator {
@Override
public String createString(int length) {
checkArgument(length > 0, "String length must be positive.");
String password = "";
StringBuilder password = new StringBuilder();
for (int i = 0; i < length; i++) {
password += iterator.next();
password.append(iterator.next());
}
switch (rule) {
case PREPEND_COUNTER:
return String.format("%04d_%s", counter++, password);
return String.format("%04d_%s", counter++, password.toString());
case DEFAULT:
default:
return password;
return password.toString();
}
}