Clean up some code quality issues

This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177182945

javatests/google/registry/rde/BrdaCopyActionTest.java

@@ -35,7 +35,6 @@ import google.registry.testing.BouncyCastleProviderRule;
 import google.registry.testing.FakeKeyringModule;
 import google.registry.testing.GcsTestingUtils;
 import google.registry.testing.GpgSystemCommandRule;
-import google.registry.testing.Providers;
 import google.registry.testing.ShardableTestCase;
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -104,9 +103,9 @@ public class BrdaCopyActionTest extends ShardableTestCase {
   public void before() throws Exception {
     action.gcsUtils = gcsUtils;
     action.ghostryde = new Ghostryde(23);
-    action.pgpCompressionFactory = new RydePgpCompressionOutputStreamFactory(Providers.of(1024));
-    action.pgpEncryptionFactory = new RydePgpEncryptionOutputStreamFactory(Providers.of(1024));
-    action.pgpFileFactory = new RydePgpFileOutputStreamFactory(Providers.of(1024));
+    action.pgpCompressionFactory = new RydePgpCompressionOutputStreamFactory(() -> 1024);
+    action.pgpEncryptionFactory = new RydePgpEncryptionOutputStreamFactory(() -> 1024);
+    action.pgpFileFactory = new RydePgpFileOutputStreamFactory(() -> 1024);
     action.pgpSigningFactory = new RydePgpSigningOutputStreamFactory();
     action.tarFactory = new RydeTarOutputStreamFactory();
     action.tld = "lol";

javatests/google/registry/rde/RdeUploadActionTest.java

@@ -69,7 +69,6 @@ import google.registry.testing.FakeSleeper;
 import google.registry.testing.GpgSystemCommandRule;
 import google.registry.testing.IoSpyRule;
 import google.registry.testing.Lazies;
-import google.registry.testing.Providers;
 import google.registry.testing.TaskQueueHelper.TaskMatcher;
 import google.registry.testing.sftp.SftpServerRule;
 import google.registry.util.Retrier;
@@ -156,21 +155,21 @@ public class RdeUploadActionTest {
         }};
 
   private final RydePgpFileOutputStreamFactory literalFactory =
-      new RydePgpFileOutputStreamFactory(Providers.of(BUFFER_SIZE)) {
+      new RydePgpFileOutputStreamFactory(() -> BUFFER_SIZE) {
         @Override
         public RydePgpFileOutputStream create(OutputStream os, DateTime modified, String filename) {
           return ioSpy.register(super.create(os, modified, filename));
         }};
 
   private final RydePgpEncryptionOutputStreamFactory encryptFactory =
-      new RydePgpEncryptionOutputStreamFactory(Providers.of(BUFFER_SIZE)) {
+      new RydePgpEncryptionOutputStreamFactory(() -> BUFFER_SIZE) {
         @Override
         public RydePgpEncryptionOutputStream create(OutputStream os, PGPPublicKey publicKey) {
           return ioSpy.register(super.create(os, publicKey));
         }};
 
   private final RydePgpCompressionOutputStreamFactory compressFactory =
-      new RydePgpCompressionOutputStreamFactory(Providers.of(BUFFER_SIZE)) {
+      new RydePgpCompressionOutputStreamFactory(() -> BUFFER_SIZE) {
         @Override
         public RydePgpCompressionOutputStream create(OutputStream os) {
           return ioSpy.register(super.create(os));
@@ -190,10 +189,11 @@ public class RdeUploadActionTest {
       action.gcsUtils = new GcsUtils(gcsService, BUFFER_SIZE);
       action.ghostryde = new Ghostryde(BUFFER_SIZE);
       action.lazyJsch =
-          Lazies.of(
+          () ->
               JSchModule.provideJSch(
                   "user@ignored",
-                  keyring.getRdeSshClientPrivateKey(), keyring.getRdeSshClientPublicKey()));
+                  keyring.getRdeSshClientPrivateKey(),
+                  keyring.getRdeSshClientPublicKey());
       action.jschSshSessionFactory = new JSchSshSessionFactory(standardSeconds(3));
       action.response = response;
       action.pgpCompressionFactory = compressFactory;

javatests/google/registry/rde/RydeGpgIntegrationTest.java

@@ -26,7 +26,6 @@ import google.registry.keyring.api.Keyring;
 import google.registry.testing.BouncyCastleProviderRule;
 import google.registry.testing.FakeKeyringModule;
 import google.registry.testing.GpgSystemCommandRule;
-import google.registry.testing.Providers;
 import google.registry.testing.ShardableTestCase;
 import google.registry.util.FormattingLogger;
 import java.io.File;
@@ -97,11 +96,11 @@ public class RydeGpgIntegrationTest extends ShardableTestCase {
     RydeTarOutputStreamFactory tarFactory =
         new RydeTarOutputStreamFactory();
     RydePgpFileOutputStreamFactory pgpFileFactory =
-        new RydePgpFileOutputStreamFactory(Providers.of(bufSize.get()));
+        new RydePgpFileOutputStreamFactory(bufSize::get);
     RydePgpEncryptionOutputStreamFactory pgpEncryptionFactory =
-        new RydePgpEncryptionOutputStreamFactory(Providers.of(bufSize.get()));
+        new RydePgpEncryptionOutputStreamFactory(bufSize::get);
     RydePgpCompressionOutputStreamFactory pgpCompressionFactory =
-        new RydePgpCompressionOutputStreamFactory(Providers.of(bufSize.get()));
+        new RydePgpCompressionOutputStreamFactory(bufSize::get);
     RydePgpSigningOutputStreamFactory pgpSigningFactory =
         new RydePgpSigningOutputStreamFactory();
 

javatests/google/registry/rde/imports/RdeContactReaderTest.java

@@ -194,8 +194,7 @@ public class RdeContactReaderTest {
     oout.writeObject(reader);
     ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
     ObjectInputStream oin = new ObjectInputStream(bin);
-    RdeContactReader result = (RdeContactReader) oin.readObject();
-    return result;
+    return (RdeContactReader) oin.readObject();
   }
 
   /** Verifies that contact id and ROID match expected values */

javatests/google/registry/rde/imports/RdeHostReaderTest.java

@@ -190,8 +190,7 @@ public class RdeHostReaderTest {
     oout.writeObject(reader);
     ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
     ObjectInputStream oin = new ObjectInputStream(bin);
-    RdeHostReader result = (RdeHostReader) oin.readObject();
-    return result;
+    return (RdeHostReader) oin.readObject();
   }
 
   /** Verifies that domain name and ROID match expected values */