Clean up some code quality issues

This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177182945
This commit is contained in:
mcilwain 2017-11-28 10:35:57 -08:00 committed by jianglai
parent 0935ba6450
commit e2db3f914e
109 changed files with 286 additions and 379 deletions

View file

@ -39,7 +39,7 @@ public class Retrier implements Serializable {
private final int attempts;
/** Holds functions to call whenever the code being retried fails. */
public static interface FailureReporter {
public interface FailureReporter {
/**
* Called after a retriable failure happened.
@ -48,7 +48,7 @@ public class Retrier implements Serializable {
*
* <p>Not called at all if the retrier succeeded on its first attempt.
*/
public void beforeRetry(Throwable thrown, int failures, int maxAttempts);
void beforeRetry(Throwable thrown, int failures, int maxAttempts);
/**
* Called after a a non-retriable error.
@ -58,7 +58,7 @@ public class Retrier implements Serializable {
*
* <p>Not called at all if the retrier succeeds.
*/
public void afterFinalFailure(Throwable thrown, int failures);
void afterFinalFailure(Throwable thrown, int failures);
}
@Inject