mirror of
https://github.com/google/nomulus.git
synced 2025-07-21 18:26:12 +02:00
Clean up some code quality issues
This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177182945
This commit is contained in:
parent
0935ba6450
commit
e2db3f914e
109 changed files with 286 additions and 379 deletions
|
@ -121,8 +121,7 @@ public class IcannHttpReporter {
|
|||
XjcIirdeaResponseElement response =
|
||||
XjcXmlTransformer.unmarshal(
|
||||
XjcIirdeaResponseElement.class, new ByteArrayInputStream(content));
|
||||
XjcIirdeaResult result = response.getResult();
|
||||
return result;
|
||||
return response.getResult();
|
||||
}
|
||||
|
||||
/** Verifies a given report filename matches the pattern tld-reportType-yyyyMM.csv. */
|
||||
|
|
|
@ -194,10 +194,7 @@ public class IcannReportingStager {
|
|||
|
||||
/** Returns a list of integers (totals) as a comma separated string. */
|
||||
private String constructTotalRow(List<Integer> totals) {
|
||||
StringBuilder rowString = new StringBuilder("Totals,,");
|
||||
rowString.append(
|
||||
totals.stream().map(Object::toString).collect(Collectors.joining(",")));
|
||||
return rowString.toString();
|
||||
return "Totals,," + totals.stream().map(Object::toString).collect(Collectors.joining(","));
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -206,8 +203,8 @@ public class IcannReportingStager {
|
|||
*
|
||||
* <p>This discards the first object, which is assumed to be the TLD field.
|
||||
* */
|
||||
private String constructRow(Iterable<? extends Object> iterable) {
|
||||
Iterator<? extends Object> rowIter = iterable.iterator();
|
||||
private String constructRow(Iterable<?> iterable) {
|
||||
Iterator<?> rowIter = iterable.iterator();
|
||||
StringBuilder rowString = new StringBuilder();
|
||||
// Skip the TLD column
|
||||
rowIter.next();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue