zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clean up some code quality issues

Browse source 
This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177182945
This commit is contained in:
mcilwain 2017-11-28 10:35:57 -08:00 • committed by jianglai
parent 0935ba6450
commit e2db3f914e
109 changed files with 286 additions and 379 deletions
Download patch file Download diff file Expand all files Collapse all files

12
java/google/registry/rdap/RdapJsonFormatter.java
View file

@ -161,7 +161,7 @@ public class RdapJsonFormatter {
/** Value as it appears in RDAP messages. */
private final String rfc7483String;
private RdapStatus(String rfc7483String) {
RdapStatus(String rfc7483String) {
this.rfc7483String = rfc7483String;
}
@ -217,7 +217,7 @@ public class RdapJsonFormatter {
/** Value as it appears in RDAP messages. */
final String rfc7483String;
private RdapEntityRole(String rfc7483String) {
RdapEntityRole(String rfc7483String) {
this.rfc7483String = rfc7483String;
}
}
@ -238,7 +238,7 @@ public class RdapJsonFormatter {
/** Value as it appears in RDAP messages. */
private final String rfc7483String;
private RdapEventAction(String rfc7483String) {
RdapEventAction(String rfc7483String) {
this.rfc7483String = rfc7483String;
}
@ -675,10 +675,8 @@ public class RdapJsonFormatter {
? union(contactResource.getStatusValues(), StatusValue.LINKED)
: contactResource.getStatusValues(),
contactResource.getDeletionTime().isBefore(now)));
if (contactType.isPresent()) {
jsonBuilder.put("roles",
ImmutableList.of(convertContactTypeToRdapRole(contactType.get())));
}
contactType.ifPresent(
type -> jsonBuilder.put("roles", ImmutableList.of(convertContactTypeToRdapRole(type))));
jsonBuilder.put("links",
ImmutableList.of(makeLink("entity", contactResource.getRepoId(), linkBase)));
// If we are logged in as the owner of this contact, create the vCard.